Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add base fee to the Block object (EIP-1559) #2663

Closed
azf20 opened this issue Jul 27, 2021 · 4 comments
Closed

Feature: add base fee to the Block object (EIP-1559) #2663

azf20 opened this issue Jul 27, 2021 · 4 comments

Comments

@azf20
Copy link
Contributor

azf20 commented Jul 27, 2021

The London hardfork introduces a change to fee markets on Ethereum (EIP-1559). This introduces a new "base fee per gas" per block, which is not currently available. Can we add this to the Block object so it is available to developers in mappings?

Discord request

@dmihal
Copy link

dmihal commented Jul 27, 2021

I created a really simple PR to add baseFee to the Block class here graphprotocol/graph-ts#197

I'm now looking into how this can be populated by the node

@leoyvens
Copy link
Collaborator

We would also need to deal with the outdated data in the block cache for existing DBs. Maybe by having a migration that clears the block cache.

@dmihal
Copy link

dmihal commented Jul 27, 2021

Created a PR (tomusdrw/rust-web3#531) to add the base fee to rust-web3, which I imagine is an upstream prerequisite for this feature

@azf20
Copy link
Contributor Author

azf20 commented Dec 1, 2021

This is available in graph-node:v0.25.0 (PR), graph-ts:v0.24.1 and graph-cli:v0.25.0. Thanks for opening @dmihal!

@azf20 azf20 closed this as completed Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants