Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subscription support to GraphQL (execution and resolvers) #275

Closed
Jannis opened this issue Aug 16, 2018 · 1 comment · Fixed by #320
Closed

Add subscription support to GraphQL (execution and resolvers) #275

Jannis opened this issue Aug 16, 2018 · 1 comment · Fixed by #320
Assignees
Labels
area/graphql enhancement New feature or request
Milestone

Comments

@Jannis
Copy link
Contributor

Jannis commented Aug 16, 2018

This includes:

  1. Adding an execute_subscription function that implements the subscribe algorithm from the GraphQL spec.
  2. Adding stream resolution to Resolver and StoreResolver.
@Jannis
Copy link
Contributor Author

Jannis commented Aug 24, 2018

Some more requirements for this:

  • When executing a subscription, identify all entity types involved in the subscription query. Use those for the store subscription.
  • When executing a subscription, get the subgraph ID from the subscription / query object and use it for the store subscription.
  • Write the following test (similar to the store subscription test):
    • run a subscription using the query runner
    • the subscription query should involve at least two entity types
    • use a mock store that simulates entity change events for all of those entity types
    • verify that two correct query results are written to the subscription result stream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/graphql enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants