Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace or de-duplicate conflicting ABI types #88

Closed
leoyvens opened this issue Aug 14, 2018 · 2 comments
Closed

Namespace or de-duplicate conflicting ABI types #88

leoyvens opened this issue Aug 14, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@leoyvens
Copy link
Collaborator

Livepeer reported that their contracts BondingManager and RoundsManager share some types, causing a name conflict when the ABIs of both contracts are added to a same mapping. The best solution would be to namespace the types by contract, but in this case since the types are equal de-duplicating would suffice.

@Jannis Jannis added the bug Something isn't working label Aug 14, 2018
@Jannis Jannis added this to the Developer Experience milestone Aug 14, 2018
@Jannis
Copy link
Contributor

Jannis commented Aug 14, 2018

Prefixing would generate long, not very user-friendly type names. I wonder if we could make it so that users can import the types they want selectively, e.g. with

import type { SomeType } from 'path/to/Contract.types.ts'

Need to think about this a bit more.

@Jannis
Copy link
Contributor

Jannis commented Apr 8, 2019

This is now possible, so we can close the issue.

@Jannis Jannis closed this as completed Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants