Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat.Req] Handle TAP payment faults #98

Closed
aasseman opened this issue Nov 14, 2023 · 0 comments · Fixed by #108
Closed

[Feat.Req] Handle TAP payment faults #98

aasseman opened this issue Nov 14, 2023 · 0 comments · Fixed by #108
Assignees
Labels
p1 High priority size:medium Medium type:feature New or enhanced functionality

Comments

@aasseman
Copy link
Collaborator

aasseman commented Nov 14, 2023

Problem statement
Currently TAP Agent ignores payment faults.

Expectation proposal
Faults can be invalid receipts (wrong value, receipt replay, etc), invalid RAVs, or aggregation denial.

For each type of fault, criteria should be determined for deciding when to stop doing business with a problematic sender.

The signal to reject a sender should be communicated promptly to the service instances for it to be effective.

EDIT:
Sender denial move to issue #103

Additional context

// TODO: Handle invalid receipts

@aasseman aasseman added size:medium Medium p1 High priority type:feature New or enhanced functionality labels Nov 14, 2023
@aasseman aasseman added this to the TAP Agent ready for prod milestone Nov 14, 2023
@aasseman aasseman self-assigned this Nov 21, 2023
@aasseman aasseman changed the title [Feat.Req] Handle TAP payment faults, communicate with service [Feat.Req] Handle TAP payment faults Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1 High priority size:medium Medium type:feature New or enhanced functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant