Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch with 2.4 source code #1677

Closed
OpenSpacesAndPlaces opened this issue May 13, 2020 · 5 comments
Closed

Branch with 2.4 source code #1677

OpenSpacesAndPlaces opened this issue May 13, 2020 · 5 comments
Labels
question Developer asks to help him deal with some problem

Comments

@OpenSpacesAndPlaces
Copy link

Is it possible to post a branch with the GraphQL 2.4 source as well as a compatible copy of GraphQL.Authorization? I tried pulling master, but it's the preview version.

I'm trying to track down a bug inside the resolver (returning [{}], but AsyncFieldResolver has data returning in the delegate).

Similar to this one from awhile ago where resolver errors need source code to trace down underlying problems:
#1014

@sungam3r sungam3r added the question Developer asks to help him deal with some problem label May 13, 2020
@sungam3r
Copy link
Member

I don’t think that someone will have the desire and time to do this and support two branches. You can fix the error in the preview version. Yes, migration is required.

@OpenSpacesAndPlaces
Copy link
Author

Maybe I'm misunderstanding something, but wouldn't there be a copy of whatever the final source was used to create the 2.4 nuget package?

@joemcbride
Copy link
Member

@sungam3r
Copy link
Member

@OpenSpacesAndPlaces I meant that hardly anyone will be engaged in constant support of old versions. But you can fetch commit tagged as 2.4.0, fix something and build your private version.

@OpenSpacesAndPlaces
Copy link
Author

That's what I was looking for - thanks much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Developer asks to help him deal with some problem
Projects
None yet
Development

No branches or pull requests

3 participants