-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatible with Distillery #111
Comments
Thanks for reporting this, suspect there might be a better solution than renaming modules. I'm not even sure why the |
@joshprice from memory the Of course, being there is not ideal. It would be good if we could have |
You can ensure protocols are consolidated by adding defmodule MyApp.Project do
def project do
[name: :myapp,
...
elixirc_paths: elixirc_paths(Mix.env)]
end
defp elixirc_paths(:test), do: ["lib", "test/support"]
defp elixirc_paths(_), do: ["lib"]
This will make sure all modules defined in I'm working on a PR for the OTP team to address the underlying issue - but in the short term, renaming modules to ensure they stay under the 100 char limit is the only workaround. |
Thanks Paul, that's good to know! Do you have a link to the OTP PR by any chance? |
I haven't submitted it yet, hoping to by the end of the day today - I'll update here once I've done so. |
I've submitted a PR here, but it's limited to better error reporting, unfortunately the 100 byte filename limit is a hard one due to the need to maintain compatibility with GNU tar's implementation. |
Distillery (issue) is unable to archive a Phoenix app using
graphql
because some of thegraphql
.beam
files' names exceed the 100 character limited imposed byerl_tar
(source).I was able to get Distillery working with this change.
I'm happy to submit it as a pull request if it is the correct fix.
The text was updated successfully, but these errors were encountered: