OSGi DS 1.2 compatibility #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 5, 2017 08:59
…llows to pack the library as OSGi bundle.
danielocampo2
approved these changes
Jul 4, 2017
runoncode
commented
Jul 4, 2017
| @@ -41,11 +41,9 @@ | |||
| import static graphql.annotations.util.NamingKit.toGraphqlName; | |||
| import static graphql.schema.GraphQLEnumType.newEnum; | |||
|
|
|||
| @Component(scope = ServiceScope.SINGLETON, property = "type=default") | |||
| @Component(property = "type=default") | |||
There was a problem hiding this comment.
Component will remain a singleton since serviceFactory=false from DS 1.2 will be used.
runoncode
commented
Jul 4, 2017
| @@ -355,6 +353,18 @@ public DefaultTypeFunction() { | |||
| typeFunctions.add(new ObjectFunction()); | |||
| } | |||
|
|
|||
| @Reference(cardinality = ReferenceCardinality.MULTIPLE, | |||
There was a problem hiding this comment.
Note: with cardinality = ReferenceCardinality.MULTIPLE we can use default policy option ReferencePolicyOption.RELUCTANT, therefore ReferencePolicyOption.GREEDY as was used before is not needed.
bbakerman
approved these changes
Jul 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the library is relying on the OSGi annotations that were introduced in the OSGi DS 1.3 which makes it impossible to deploy inside Equinox container that is widely used by many organisations.
This PR does two things: