Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter parseValue coercion for built-in scalars #3191

Closed
dondonz opened this issue Apr 18, 2023 · 1 comment
Closed

Stricter parseValue coercion for built-in scalars #3191

dondonz opened this issue Apr 18, 2023 · 1 comment

Comments

@dondonz
Copy link
Member

dondonz commented Apr 18, 2023

This is an issue to track the progress of stricter parseValue coercion for built-in scalars.

Background

We initially made parseValue coercion stricter for built-in scalars to align with the JS reference implementation, and these changes were included in the v20.0 release. https://github.com/graphql-java/graphql-java/releases/tag/v20.0

Since then we've received reports that this breaking change is challenging. Although it's in line with the JS implementation, this change can potentially break clients. The plan is to provide a better migration pathway.

Progress log

@dondonz
Copy link
Member Author

dondonz commented Jul 11, 2023

With today's release of v21.0, we're including an extra monitoring and interceptor callback for parseValue scalar coercion. See the release notes for more information: https://github.com/graphql-java/graphql-java/releases/tag/v21.0

We'll be adding the stricter scalar coercion at some point in the future, so please make use of these callbacks to learn which incoming values will be affected. I'll close the issue for now as we have reverted the stricter coercion in v20.3 and released the migration pathway in v21.0.

@dondonz dondonz closed this as completed Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@dondonz and others