Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

displayOptions.skipRelay not evaluated?! #23

Closed
Michael-Hofer opened this issue May 23, 2017 · 4 comments
Closed

displayOptions.skipRelay not evaluated?! #23

Michael-Hofer opened this issue May 23, 2017 · 4 comments

Comments

@Michael-Hofer
Copy link

Following the readme I'd assume I can set displayOptions when rendering Voyager in the body.
Based on the index.html from the sample I have the following code:

      // Render <Voyager /> into the body.
      GraphQLVoyager.init(document.getElementById('voyager'), {
          introspection: introspectionProvider,
          displayOptions: { skipRelay: false, rootType: 'HealthQuery', sortByAlphabet: true }
      });

The rendering works fine, but the skipRelay: false option is not considered (rootType and sortByAlphabet are not considered also).
Is something wrong with the init given above or is this a bug?

@RomanHotsiy
Copy link
Collaborator

Which voyager version are you using?

@Michael-Hofer
Copy link
Author

I am using version graphql-voyager-1.0.0-rc.0 from the releases page (the files from the dist folder)

@RomanHotsiy
Copy link
Collaborator

This was a bug in the Readme.
These options were landed in rc.1
Use 1.0.0-rc.3, please.
I have updated README

@Michael-Hofer
Copy link
Author

Thanks for the advice.
It works fine now with rc.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants