Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate plugin onInstall return for consistent API #637

Merged
merged 1 commit into from Nov 18, 2020

Conversation

tgriesser
Copy link
Member

Removes the {types: NexusAcceptedTypeDef[]} return value from onInstall plugin api in favor of imperative hasType / addType APIs, for consistency.

@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #637 (ab97971) into develop (36503f7) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #637      +/-   ##
===========================================
- Coverage    92.79%   92.77%   -0.02%     
===========================================
  Files           42       42              
  Lines         2663     2659       -4     
  Branches       579      579              
===========================================
- Hits          2471     2467       -4     
  Misses         192      192              

Copy link
Member

@jasonkuhrt jasonkuhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgriesser tgriesser merged commit 94ba687 into develop Nov 18, 2020
@tgriesser tgriesser deleted the tgriesser/feat/consistent-plugin-return branch November 18, 2020 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants