Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: resolveType warning, restore declarativeWrapping list behavior #658

Merged
merged 3 commits into from Nov 23, 2020

Conversation

tgriesser
Copy link
Member

  • Don't worry if we use both chaining & wrapping, they should be able to co-exist just fine
  • Previously list: true, nullable: false would lead to -> [Type!]!, this enables that in the declarativeWrapping plugin
  • Add a warning message w/ links to the t.resolveType usages

@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #658 (874bda7) into develop (306dbaa) will decrease coverage by 0.24%.
The diff coverage is 87.50%.

@@             Coverage Diff             @@
##           develop     #658      +/-   ##
===========================================
- Coverage    94.19%   93.94%   -0.25%     
===========================================
  Files           44       44              
  Lines         2806     2809       +3     
  Branches       648      648              
===========================================
- Hits          2643     2639       -4     
- Misses         161      168       +7     
  Partials         2        2              

@tgriesser tgriesser merged commit bff7008 into develop Nov 23, 2020
@tgriesser tgriesser deleted the tgriesser/chore/improve-error-messages branch November 23, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant