feat: Connection plugin features & fixes #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #674 +/- ##
===========================================
+ Coverage 93.62% 93.63% +0.01%
===========================================
Files 44 44
Lines 2869 2877 +8
Branches 670 676 +6
===========================================
+ Hits 2686 2694 +8
Misses 181 181
Partials 2 2 |
jasonkuhrt
approved these changes
Nov 26, 2020
Weakky
reviewed
Nov 26, 2020
| t2.field(key, val) | ||
| t2.field(key, { | ||
| ...val, | ||
| resolve: (fieldConfig as any).edgeFields?.[key] ?? defaultFieldResolver, |
There was a problem hiding this comment.
I fixed the pluginExtendConnection but forgot that one indeed in #569 🤦♂️ (minus the defaultFieldResolver fallback 🙈)
Weakky
approved these changes
Nov 26, 2020
Will skip requiring global extension fields
tgriesser
force-pushed
the
tgriesser/feat/connection-fixes-450-515
branch
from
4b9f850
to
6220d85
Compare
|
Done. Merged as rebase into develop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #450 custom edge fields are not being resolved
feat: #515 allow connection plugin cursor to be non-string type
feat: #399, add requireResolver: false to skip requiring global extension fields
feat: #479, allow promise to be returned from pageInfoFromNodes
feat: #456, export connection plugin args