Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support subscriptions #120

Open
jason-curtis opened this issue Feb 23, 2017 · 20 comments
Open

Support subscriptions #120

jason-curtis opened this issue Feb 23, 2017 · 20 comments

Comments

@jason-curtis
Copy link
Contributor

Subscription support was added to graphene in graphql-python/graphene#35. It would be awesome to have it built in to graphene-django so that we can build real-time apps with it!

@BossGrand
Copy link
Member

This is being talked about here in graphene

graphql-python/graphene#430

@eamigo86
Copy link

eamigo86 commented Dec 5, 2017

Hi @thatneat, please, visit this module might interest you to use subscriptions on graphene-django

@mvanlonden
Copy link
Member

Subscriptions added in v2 https://github.com/graphql-python/graphene/releases/tag/v2.0.0

@mvanlonden
Copy link
Member

Reopening to add native support for subscriptions using channels

@firaskafri
Copy link
Collaborator

@eamigo86 what are your thoughts regarding adding subscriptions to the django-graphene repo?

@stale
Copy link

stale bot commented Jun 11, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 11, 2019
@stale stale bot closed this as completed Jun 18, 2019
@fkromer
Copy link

fkromer commented Jan 29, 2020

@firaskafri @eamigo86 The package graphene-subscriptions has great integration of GraphQL subscriptions with Django models. Probably it would be valueable to get in contact with the lead dev for possible integration as well.

@Suor
Copy link

Suor commented Apr 16, 2020

So there is no advised way to do that?

@Eraldo
Copy link

Eraldo commented May 10, 2020

I am also a bit hesitant to use graphene-subscriptions since the last commit was nearly half a year ago.

Are subscriptions on the roadmap? Is there such a thing? 😊

@ulgens
Copy link
Collaborator

ulgens commented May 11, 2020

@jkimbo Around 3.2 or 3.3 maybe? I can allocate some time for this.

@ulgens ulgens reopened this May 11, 2020
@stale stale bot removed the wontfix label May 11, 2020
@ulgens
Copy link
Collaborator

ulgens commented May 11, 2020

I'm reopening the issue btw. This is a missing feature in graphene-django side, that's for certain.

@jaydenwindle
Copy link

Hi all! Author of graphene-subscriptions here 😊

It would be awesome to see subscriptions support added to graphene-django. I'm happy to submit a PR with my subscriptions implementation if there is interest in integrating it into this library.

One challenge with implementing subscriptions in graphene-django v2 right now is that you need to stitch together the async-based pattern that Django Channels uses with the Observable-based pattern used in graphene. This is what graphene-subscriptions does currently.

(Side note: @Eraldo I can definitely understand your concern there! Rest assured that I'm still actively supporting it (I'm hoping to ship graphene-subscriptions v2 very soon). Feel free to open an issue or DM me if you have any questions!)

Once graphene-django v3 ships with support for async resolvers, implementing built-in support for subscriptions will be much simpler and the implementation will be much cleaner.

@jkimbo I would love to help ship subscriptions support for graphene-django if that's something you and the team would be interested in supporting natively.

@SmileyChris
Copy link

Also, if you're looking for an alternative, I'm the author of the graphql-ws branch handling django channels 2 subscriptions. Hopefully will have that merged to master soon (but actively using the branch in a pre-production environment successfully).

Seems like there's gaining traction on multiple solutions that are getting this done. Also happy to help work on (or consult on) a built in solution if it fits.

@Eraldo
Copy link

Eraldo commented Jun 16, 2020

This seems to be another option that I want to include for completion's sake: https://github.com/datadvance/DjangoChannelsGraphqlWs

@stale
Copy link

stale bot commented Aug 27, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Aug 27, 2020
@ulgens ulgens removed the wontfix label Aug 28, 2020
@Eraldo
Copy link

Eraldo commented Sep 21, 2020

Any updates? hopeful-eyes
Any clue which 3rd party library is more/less likely to make it into graphene-django at some point?

@Ahtii
Copy link

Ahtii commented Jan 29, 2021

Anyone please help i am stuck in creating custom view (instead of GraphiQL) for subscription i am using @jaydenwindle 's graphene-subscription](https://pypi.org/project/graphene-subscriptions/) package here is the link to my problem.

@Eraldo
Copy link

Eraldo commented Jul 19, 2022

It has been over a year and a half since the last comment. sigh

@procopio420
Copy link

all available libraries that I found has a lot of dependency problem with newer graphene versions :/ and implementing it by hand is being painful

@prokher
Copy link

prokher commented Apr 27, 2023

We just published a huge update to DjangoChannelsGraphqlWs to support latest Django, Graphene & GraphQL-core. We still be happy to see subscriptions natively supported in Graphene & GraphQL-core, but until they are not there we stick to our own implementation, e.g. to DjangoChannelsGraphqlWs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests