Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings for unittests missing in package #820

Closed
crazyscientist opened this issue Dec 4, 2019 · 9 comments · Fixed by #1034
Closed

Settings for unittests missing in package #820

crazyscientist opened this issue Dec 4, 2019 · 9 comments · Fixed by #1034

Comments

@crazyscientist
Copy link
Contributor

Hi there,

I'm trying to build an RPM package on https://build.opensuse.org based on the package at PyPI and run the unittests during the build process. But I kind of miss a settings module I can use.

Would you mind including e.g. django_test_settings.py in the next release?

@jkimbo
Copy link
Member

jkimbo commented Dec 7, 2019

Sounds reasonable though I'm not that familiar with the pip deploy process. @crazyscientist what would I need to change in the setup.py to get it to include that file?

@crazyscientist
Copy link
Contributor Author

@jkimbo, I would do the following:

  • Move django_test_settings.py to the test directory
  • Remove the exclusion statement for the tests subpackage
  • Adjust the MANIFEST in case the tests rely on data files

Would you prefer me submitting a PR?

@jkimbo
Copy link
Member

jkimbo commented Dec 27, 2019

@crazyscientist sorry for the delay: yes a PR would be great thanks!

@stale
Copy link

stale bot commented Apr 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 25, 2020
@jkimbo
Copy link
Member

jkimbo commented Apr 25, 2020

@crazyscientist do you have time to make that PR?

@crazyscientist
Copy link
Contributor Author

@crazyscientist do you have time to make that PR?

@jkimbo, sorry, I was stuck with another project. I might be able to get around to this; maybe next week?

@stale
Copy link

stale bot commented Aug 27, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Aug 27, 2020
@ulgens ulgens removed the wontfix label Aug 28, 2020
@ulgens
Copy link
Collaborator

ulgens commented Aug 28, 2020

@crazyscientist Any hope there? 🙂

@crazyscientist
Copy link
Contributor Author

Any hope there? 🙂

@ulgens Finally, inspiration struck. I hope the changes I propose in my PR will work for you as well 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants