Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for MultipolygonField #62

Closed
heronrs opened this issue Jan 11, 2019 · 2 comments
Closed

Support for MultipolygonField #62

heronrs opened this issue Jan 11, 2019 · 2 comments
Assignees

Comments

@heronrs
Copy link

heronrs commented Jan 11, 2019

Hey guys, just came accross the need for a PolygonField representation.

I tried hacking my way into it by looking at #58 and it seemed very straightforward.

Could give it a shot and send PR if that's OK

@heronrs heronrs changed the title Support for PolygonField Support for MultipolygonField Jan 11, 2019
@abawchen
Copy link
Collaborator

@heron182

Thanks for the feedback! 👍

I just refactored the way to resolve PointField into type and coordinates automatically, that we don't have to call json.load to parse PointField.

You can refer #64 for the detail -- it would be more complex than converting it into json string, but I think it would be more friendly for the usage.

@heronrs
Copy link
Author

heronrs commented Jan 17, 2019

Great @abawchen , I'll send a PR as soon as I can :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants