Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove leading whitespaces in multi-line descriptions #1490

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

firaskafri
Copy link
Contributor

@firaskafri firaskafri commented Jan 6, 2023

Currently Scalar types and Field types pass description without touching it which is causing the issue of inconsistent white spaces in the case of multi-line descriptions when parsed by federation services.

Addressing issue #1489

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Base: 95.98% // Head: 95.99% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (2feabac) compared to base (340d5ed).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1490   +/-   ##
=======================================
  Coverage   95.98%   95.99%           
=======================================
  Files          51       51           
  Lines        1742     1746    +4     
=======================================
+ Hits         1672     1676    +4     
  Misses         70       70           
Impacted Files Coverage Δ
graphene/types/field.py 96.07% <100.00%> (+0.07%) ⬆️
graphene/types/unmountedtype.py 91.66% <100.00%> (+1.19%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant