Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphene as a validation library #72

Closed
ustun opened this issue Dec 15, 2015 · 2 comments
Closed

Graphene as a validation library #72

ustun opened this issue Dec 15, 2015 · 2 comments
Labels

Comments

@ustun
Copy link
Contributor

ustun commented Dec 15, 2015

This is probably not the best place to discuss this as it is not a bug report, but I was wondering how we should approach data validation with graphql and graphene, especially with its Django integration.

For example, should graphene replace the django forms layer as well? I believe it should and it can, since its validation capabilities are much richer. It is possible to validate if something is a string in django, but going beyond that, for example, ensuring a value is a list of strings is not possible without custom code.

We should discuss and document the best practices here.

I see graphene as ultimately replacing the urls, views and forms parts of django.

@syrusakbary
Copy link
Member

@adamcharnock is working in #60, which apart of the main propose (filtering in django connections) provides a way for mapping also forms into Graphene types.

@syrusakbary
Copy link
Member

Right now the code merged by #60 into master allows to convert any kind of form with its fields to a Graphene Type.

Closing this issue, please reopen if any questions or suggestions ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants