Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package name rewrite #33

Open
Sytten opened this issue Feb 2, 2021 · 4 comments
Open

Package name rewrite #33

Sytten opened this issue Feb 2, 2021 · 4 comments

Comments

@Sytten
Copy link
Member

Sytten commented Feb 2, 2021

Ok I am back on this project.
I propose that we change the name of package to @graphql-query-rewriter/core.
That will allow us to create other packages like @graphq-query-rewriter/express and @graphq-query-rewriter/apollo.
We might want to consolidate that in a monorepo or keep them in separate repo.
What do you think @chanind @mattetre

@chanind
Copy link
Collaborator

chanind commented Feb 2, 2021

That sounds good to me! I'd prefer not a monorepo since I feel like it's harder to manage, but I don't have a super strong opinion if you think it makes more sense

@Sytten
Copy link
Member Author

Sytten commented Feb 2, 2021

I don't have a strong opinion on monorepo, but it is not too bad with pnpm or yarn 2. We can keep them separate for now. I don't have a lot of permissions on the org so I will need you to make the changes. I would also appreciate if you could add an organization secret for the nom publish so I can start migrating the CI.

@chanind
Copy link
Collaborator

chanind commented Feb 2, 2021

Just increased your access level for the github org, so you should be able to do anything you need to set up repos

@chanind
Copy link
Collaborator

chanind commented Feb 2, 2021

Could you send me an email at chanindav@gmail.com? It's probably easier to coordinate the npm stuff that way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants