Adding the normalize_query_types feature to normalize all generated to CamelCase.

[markcatley]

This probably isn't the final solution to this issue but I made this change so that I could continue with what I was implementing. At a minimum, the readme would need to be updated to describe the feature.

I have added the normalize_query_types that normalises types (structs, type aliases, etc) generated by the code-gen to use CamelCase as it is my understanding that this is idiomatic rust. I have done this as a feature as it's potentially a breaking change.

I was having issues with scalars as described in #254 but then noticed that other types were non-idiomatic.

Fixes #254 and fixes #255.

[davidgraeff]

Seems like you solve #255 indeed in a more comprehensive way than I did. I'm not sure if it should be hidden behind a feature flag. It current way breaks generated code and the transformations should always happen imo. I don't think backwards compatibility is an issue because this could never have worked for anyone before.

Why do you introduce an online test and don't follow the _cli tests structure with schema+query files?

[markcatley]

Thank you.

I am definitely happy for it not to be behind a feature flag, however, it is definitely a breaking change. For example, if you go into the github example and turn the feature flag on then you get the following error:

error[E0412]: cannot find type `Uri` in module `super`
  --> src/main.rs:10:10
   |
10 | #[derive(GraphQLQuery)]
   |          ^^^^^^^^^^^^ not found in `super`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0412`.
error: Could not compile `graphql_query_github_example`.

I really wasn't sure how to test this so I created the new example so it can most likely be done in a better way. I don't follow where you're suggesting it should be tested. What is the path to the files you're talking about?

[davidgraeff]

Tests are in graphql_client/tests. I would have expected most of them to be in the _codegen directory like the github test, but I'm not really opinionated.

[tomhoule]

Sorry for the delayed reply, I'm on vacations at the moment :)

I also think this should be the default. It's unambiguous that we should convert from snake case to camel case. The one in the GitHub example is more puzzling, as it's a renaming from URI to Uri, which is not intuitive. We could think about only doing the case transformation if

• there is an underscore in the type (excluding the introspection types maybe), or
• it starts with a lowercase letter

What do you think?

[tomhoule]

We should also document it (I could do it if you don't have the time).

[davidgraeff]

there is an underscore in the type (excluding the introspection types maybe), or
it starts with a lowercase letter

If you introduce rules for the transformation, there will be people tripping over those one or two odd named types in their schemas. I'd say the transformation should happen all the time, imo.

[tomhoule]

Sorry for the delay! I think we should merge this with the feature at first, we can think about removing it later, I'll try to find the time to rebase and merge (it's great if you want to rebase yourself of course :))

[tomhoule]

Update: I'm fixing the merge conflicts right now.

[tomhoule]

Merged in 26db903 and added to the changelog :) We'll probably make this the default eventually. Thanks a lot!

[mathstuf]

See #283 for some problems I saw when trying to address #281. PR incoming shortly.