swift4 support

[Igor-Palaguta]

Hello,

Thank you for great library! It works perfectly

Do you have in nearest plans migrate it to swift 4. With few fixes it can be compiled with swift4, but testIntrospectionCharacterKindQuery fails with EXC_BAD_ACCESS here:

GraphQL/Sources/GraphQL/Reflection/AnyExistentialContainer.swift

Line 15 in 045bae9

return unsafeBitCast(self, to: Any.self)

[johntaschereau]

Please allow me to bump-up and add my voice to this request. This outstanding project (from a utility and educational perspective) hasn't worked due to the use of unsafeBitCast with Swift 4. I attempted to fix using Mike Ash's excellent article "Swift Unmanaged" (https://mikeash.com/pyblog/friday-qa-2017-08-11-swiftunmanaged.html) but without success this far. Thank you.

[paulofaria]

@bradhilton Brad! Do you have any idea how to fix this?

[johntaschereau]

Mike Ash's August 2017 article "Swift Unmanaged" has a very clear paragraph at the onset: "The first task is converting a reference into the raw bytes for a void *, or converting the raw bytes of a void * back to a reference. Since Swift references are implemented as pointers, this is straightforward. It's really just a matter of getting the type system to cooperate. You can do this with unsafeBitCast, although I strongly recommend against it. If these details ever changed, you'd be in trouble, whereas Unmanaged will continue to work." … His article then goes on to explain how to use updated Swift and avoid UnsafeBitCast. I believe this article is the blueprint for addressing this issue in GraphQL. Mr. Palaguta's work appears outstanding however with the protocols and such, I wasn't clear enough given the time I had to see about replacing UnsafeBitCast with Mike Ash's tips. I believe it can be done. I thought I would ask Mr. Palaguta and did when the Issue opened because he knows his software best. I remain convinced the article I cite by Mr. Ash can be used to effect the requisite changes.

[bradhilton]

@Igor-Palaguta @johntaschereau @paulofaria I'm going to push an new build of Reflection supporting Swift 4 shortly

EDIT: Just pushed new build 0.15.0 that supports Swift 4

[paulofaria]

@Igor-Palaguta are you willing to send a PR updating GraphQL's Reflection module with https://github.com/Zewo/Reflection?

[jseibert]

Any progress here? Let me know what I can do to be helpful.

[paulofaria]

@jseibert I believe the only thing needed it to pull the code from https://github.com/Zewo/Reflection and update GraphQL's Reflection module

[paulofaria]

@jseibert if you can send a PR that would be very helpful! 😊

[jseibert]

#27

@Igor-Palaguta I incorporated your changes as well. All tests now pass.

[paulofaria]

fixed by #27

[jseibert]

@paulofaria can we get a new release that ships this?

[paulofaria]

@jseibert of course! sorry I forgot to release.

[paulofaria]

released here:

https://github.com/GraphQLSwift/GraphQL/releases/tag/0.3.0

[jseibert]

Wow, you're fast! Awesome, thanks!

[jseibert]

@paulofaria just opened a PR on Graphiti as well for you.

[lightwave]

Is the reason to keep those deprecated usage of String.characters around in the code base to maintain backward compatibility with Swift 3?