Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor how radio button groups are handled #145

Closed
grapoza opened this issue Mar 31, 2020 · 0 comments · Fixed by #146
Closed

Refactor how radio button groups are handled #145

grapoza opened this issue Mar 31, 2020 · 0 comments · Fixed by #146
Assignees
Labels
enhancement New feature or request
Projects

Comments

@grapoza
Copy link
Owner

grapoza commented Mar 31, 2020

Radio button group initialization (basically the selection of a single radio button from a group) is currently done through a hacky radioGroupValues property on the tree. Internally it's fine, but it's not a great UX for anyone who wants to initialize radio button group selection, and there's no external need for it beyond that since the tree exposes a getCheckedRadioButons method.

A new value should be accepted on the tree view spec for a node to indicate it should be initially selected. This will simplify the prop surface of the TreeView component, and hopefully make tree view radio button initialization more intuitive.

@grapoza grapoza added the enhancement New feature or request label Mar 31, 2020
@grapoza grapoza self-assigned this Mar 31, 2020
@grapoza grapoza added this to To do in v2.0.0 via automation Mar 31, 2020
@grapoza grapoza moved this from To do to In progress in v2.0.0 Mar 31, 2020
v2.0.0 automation moved this from In progress to Done Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
v2.0.0
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant