Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reusable 'Resource loading' presentation #2

Merged
merged 21 commits into from Oct 6, 2022
Merged

Reusable 'Resource loading' presentation #2

merged 21 commits into from Oct 6, 2022

Conversation

grav0211
Copy link
Owner

@grav0211 grav0211 commented Oct 6, 2022

  • Introduce reusable LoadResourcePresenter.
  • Replace custom FeedPresenter and FeedImagePresenter logic with LoadResourcePresenter to eliminate duplication.

@grav0211
Duplicate FeedPresenter as LoadResourcePresenter
2920c1d
@grav0211
Remove title from generic presenter since it's specific to each prese…
c1c9881 
…nter
@grav0211
Rename didStartLoadingFeed method to didStartLoading
e9f6306
@grav0211
Displays mapped resource on successful resource loading
0f319ed
@grav0211
Make LoadResourcePresenter generic over the Resource types
2ceeca0
@grav0211
Replace "FEED_VIEW_CONNECTION_ERROR" key with "GENERIC_CONNECTION_ERROR"
9ce794f
@grav0211
Move "GENERIC_CONNECTION_ERROR" localization key to new Shared.strings
b315217
@grav0211
Remove duplication in the localization tests
60e6ca6
@grav0211
Rename and move ResourceLoadingView and VIewModel to Shared module
eb45e31
@grav0211
Rename and move ResourceErrorView and ViewModel to Shared module
911164d
@grav0211
Add FeedPresenter map
2b586cb
@grav0211
Replace FeedPresenter with generic presenter
3cbcded
@grav0211
Remove unused FeedPresenter logic
4040f0b
@grav0211
Inline param
ae65c6e
@grav0211
Make Presentation Adapter generic so it can be reused
31c324d
@grav0211
Add FeedImagePresenter map
020c75c
@grav0211
Display error on mapper error
d68eea2
@grav0211
Replace FeedImagePresenter with LoadResourcePresenter
ab72df2
@grav0211
Remove unused FeedImagePresenter logic
2ddd941
@grav0211
Add type aliases to shorten type definitions with generics
e256090
@grav0211
Move UIImage creation to a tryMake extension
6dba0b5
@grav0211 grav0211 merged commit 31f80b7 into feature/image-comments-presenter/integration Oct 6, 2022
@grav0211 grav0211 deleted the feature/image-comments-presenter/resource-loading-presentation branch October 6, 2022 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@grav0211