-
Notifications
You must be signed in to change notification settings - Fork 1.7k
/
auth_test.go
345 lines (327 loc) · 10.6 KB
/
auth_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
/*
* Teleport
* Copyright (C) 2023 Gravitational, Inc.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
package proxy
import (
"context"
"crypto/tls"
"errors"
"net/http"
"os"
"path/filepath"
"testing"
"github.com/google/go-cmp/cmp"
"github.com/google/go-cmp/cmp/cmpopts"
"github.com/jonboulle/clockwork"
"github.com/stretchr/testify/require"
"golang.org/x/exp/maps"
authzapi "k8s.io/api/authorization/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/client-go/kubernetes"
authztypes "k8s.io/client-go/kubernetes/typed/authorization/v1"
"k8s.io/client-go/rest"
"k8s.io/client-go/transport"
"github.com/gravitational/teleport/api/types"
testingkubemock "github.com/gravitational/teleport/lib/kube/proxy/testing/kube_server"
"github.com/gravitational/teleport/lib/service/servicecfg"
"github.com/gravitational/teleport/lib/utils"
)
func TestCheckImpersonationPermissions(t *testing.T) {
tests := []struct {
desc string
sarErr error
allowedVerbs []string
allowedResources []string
errAssertion require.ErrorAssertionFunc
}{
{
desc: "request failure",
sarErr: errors.New("uh oh"),
errAssertion: require.Error,
},
{
desc: "all permissions granted",
allowedVerbs: []string{"impersonate"},
allowedResources: []string{"users", "groups", "serviceaccounts"},
errAssertion: require.NoError,
},
{
desc: "missing some permissions",
allowedVerbs: []string{"impersonate"},
allowedResources: []string{"users"},
errAssertion: require.Error,
},
}
for _, tt := range tests {
mock := &mockSARClient{
err: tt.sarErr,
allowedVerbs: tt.allowedVerbs,
allowedResources: tt.allowedResources,
}
err := checkImpersonationPermissions(context.Background(), "test", mock)
tt.errAssertion(t, err)
}
}
type mockSARClient struct {
authztypes.SelfSubjectAccessReviewInterface
err error
allowedVerbs []string
allowedResources []string
}
func (c *mockSARClient) Create(_ context.Context, sar *authzapi.SelfSubjectAccessReview, _ metav1.CreateOptions) (*authzapi.SelfSubjectAccessReview, error) {
if c.err != nil {
return nil, c.err
}
var verbAllowed, resourceAllowed bool
for _, v := range c.allowedVerbs {
if v == sar.Spec.ResourceAttributes.Verb {
verbAllowed = true
break
}
}
for _, r := range c.allowedResources {
if r == sar.Spec.ResourceAttributes.Resource {
resourceAllowed = true
break
}
}
sar.Status.Allowed = verbAllowed && resourceAllowed
return sar, nil
}
func alwaysSucceeds(context.Context, string, authztypes.SelfSubjectAccessReviewInterface) error {
return nil
}
func failsForCluster(clusterName string) servicecfg.ImpersonationPermissionsChecker {
return func(ctx context.Context, cluster string, a authztypes.SelfSubjectAccessReviewInterface) error {
if cluster == clusterName {
return errors.New("Kaboom")
}
return nil
}
}
func TestGetKubeCreds(t *testing.T) {
t.Parallel()
// kubeMock is a Kubernetes API mock for the session tests.
kubeMock, err := testingkubemock.NewKubeAPIMock()
require.NoError(t, err)
t.Cleanup(func() { kubeMock.Close() })
targetAddr := kubeMock.Address
rbacSupportedTypes := maps.Clone(defaultRBACResources)
rbacSupportedTypes[allowedResourcesKey{apiGroup: "resources.teleport.dev", resourceKind: "teleportroles"}] = utils.KubeCustomResource
rbacSupportedTypes[allowedResourcesKey{apiGroup: "resources.teleport.dev", resourceKind: "teleportroles/status"}] = utils.KubeCustomResource
logger := utils.NewLoggerForTests()
ctx := context.TODO()
const teleClusterName = "teleport-cluster"
dir := t.TempDir()
kubeconfigPath := filepath.Join(dir, "kubeconfig")
data := []byte(`
apiVersion: v1
kind: Config
clusters:
- cluster:
server: ` + kubeMock.URL + `
insecure-skip-tls-verify: true
name: example
contexts:
- context:
cluster: example
user: creds
name: foo
- context:
cluster: example
user: creds
name: bar
- context:
cluster: example
user: creds
name: baz
users:
- name: creds
current-context: foo
`)
err = os.WriteFile(kubeconfigPath, data, 0o600)
require.NoError(t, err)
tests := []struct {
desc string
kubeconfigPath string
kubeCluster string
serviceType KubeServiceType
impersonationCheck servicecfg.ImpersonationPermissionsChecker
want map[string]*kubeDetails
assertErr require.ErrorAssertionFunc
}{
{
desc: "kubernetes_service, no kube creds",
serviceType: KubeService,
impersonationCheck: alwaysSucceeds,
assertErr: require.Error,
want: map[string]*kubeDetails{},
}, {
desc: "proxy_service, no kube creds",
serviceType: ProxyService,
impersonationCheck: alwaysSucceeds,
assertErr: require.NoError,
want: map[string]*kubeDetails{},
}, {
desc: "legacy proxy_service, no kube creds",
serviceType: ProxyService,
impersonationCheck: alwaysSucceeds,
assertErr: require.NoError,
want: map[string]*kubeDetails{},
}, {
desc: "kubernetes_service, with kube creds",
serviceType: KubeService,
kubeconfigPath: kubeconfigPath,
impersonationCheck: alwaysSucceeds,
want: map[string]*kubeDetails{
"foo": {
kubeCreds: &staticKubeCreds{
targetAddr: targetAddr,
transportConfig: &transport.Config{},
kubeClient: &kubernetes.Clientset{},
clientRestCfg: &rest.Config{},
},
kubeCluster: mustCreateKubernetesClusterV3(t, "foo"),
rbacSupportedTypes: rbacSupportedTypes,
},
"bar": {
kubeCreds: &staticKubeCreds{
targetAddr: targetAddr,
transportConfig: &transport.Config{},
kubeClient: &kubernetes.Clientset{},
clientRestCfg: &rest.Config{},
},
kubeCluster: mustCreateKubernetesClusterV3(t, "bar"),
rbacSupportedTypes: rbacSupportedTypes,
},
"baz": {
kubeCreds: &staticKubeCreds{
targetAddr: targetAddr,
transportConfig: &transport.Config{},
kubeClient: &kubernetes.Clientset{},
clientRestCfg: &rest.Config{},
},
kubeCluster: mustCreateKubernetesClusterV3(t, "baz"),
rbacSupportedTypes: rbacSupportedTypes,
},
},
assertErr: require.NoError,
}, {
desc: "proxy_service, with kube creds",
kubeconfigPath: kubeconfigPath,
serviceType: ProxyService,
impersonationCheck: alwaysSucceeds,
want: map[string]*kubeDetails{},
assertErr: require.NoError,
}, {
desc: "legacy proxy_service, with kube creds",
kubeconfigPath: kubeconfigPath,
serviceType: LegacyProxyService,
impersonationCheck: alwaysSucceeds,
want: map[string]*kubeDetails{
teleClusterName: {
kubeCreds: &staticKubeCreds{
targetAddr: targetAddr,
transportConfig: &transport.Config{},
kubeClient: &kubernetes.Clientset{},
clientRestCfg: &rest.Config{},
},
kubeCluster: mustCreateKubernetesClusterV3(t, teleClusterName),
rbacSupportedTypes: rbacSupportedTypes,
},
},
assertErr: require.NoError,
}, {
desc: "Missing cluster does not fail operation",
kubeconfigPath: kubeconfigPath,
serviceType: KubeService,
impersonationCheck: failsForCluster("bar"),
want: map[string]*kubeDetails{
"foo": {
kubeCreds: &staticKubeCreds{
targetAddr: targetAddr,
transportConfig: &transport.Config{},
kubeClient: &kubernetes.Clientset{},
clientRestCfg: &rest.Config{},
},
kubeCluster: mustCreateKubernetesClusterV3(t, "foo"),
rbacSupportedTypes: rbacSupportedTypes,
},
"bar": {
kubeCreds: &staticKubeCreds{
targetAddr: targetAddr,
transportConfig: &transport.Config{},
kubeClient: &kubernetes.Clientset{},
clientRestCfg: &rest.Config{},
},
kubeCluster: mustCreateKubernetesClusterV3(t, "bar"),
rbacSupportedTypes: rbacSupportedTypes,
},
"baz": {
kubeCreds: &staticKubeCreds{
targetAddr: targetAddr,
transportConfig: &transport.Config{},
kubeClient: &kubernetes.Clientset{},
clientRestCfg: &rest.Config{},
},
kubeCluster: mustCreateKubernetesClusterV3(t, "baz"),
rbacSupportedTypes: rbacSupportedTypes,
},
},
assertErr: require.NoError,
},
}
for _, tt := range tests {
tt := tt
t.Run(tt.desc, func(t *testing.T) {
t.Parallel()
fwd := &Forwarder{
clusterDetails: map[string]*kubeDetails{},
cfg: ForwarderConfig{
ClusterName: teleClusterName,
KubeServiceType: tt.serviceType,
KubeconfigPath: tt.kubeconfigPath,
CheckImpersonationPermissions: tt.impersonationCheck,
Clock: clockwork.NewFakeClock(),
},
log: logger,
}
err := fwd.getKubeDetails(ctx)
tt.assertErr(t, err)
if err != nil {
return
}
require.Empty(t, cmp.Diff(fwd.clusterDetails, tt.want,
cmp.AllowUnexported(staticKubeCreds{}),
cmp.AllowUnexported(kubeDetails{}),
cmpopts.IgnoreFields(kubeDetails{}, "rwMu", "kubeCodecs", "wg", "cancelFunc", "gvkSupportedResources"),
cmp.Comparer(func(a, b *transport.Config) bool { return (a == nil) == (b == nil) }),
cmp.Comparer(func(a, b *tls.Config) bool { return true }),
cmp.Comparer(func(a, b *kubernetes.Clientset) bool { return (a == nil) == (b == nil) }),
cmp.Comparer(func(a, b *rest.Config) bool { return (a == nil) == (b == nil) }),
cmp.Comparer(func(a, b http.RoundTripper) bool { return true }),
))
})
}
}
func mustCreateKubernetesClusterV3(t *testing.T, name string) *types.KubernetesClusterV3 {
kubeCluster, err := types.NewKubernetesClusterV3(types.Metadata{
Name: name,
}, types.KubernetesClusterSpecV3{})
require.NoError(t, err)
return kubeCluster
}