Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestPingConnection flakiness #15896

Closed
espadolini opened this issue Aug 29, 2022 · 4 comments · Fixed by #15969
Closed

TestPingConnection flakiness #15896

espadolini opened this issue Aug 29, 2022 · 4 comments · Fixed by #15969
Assignees

Comments

@espadolini
Copy link
Contributor

Failure

Link(s) to logs

Relevant snippet

=== RUN   TestPingConnection/ConcurrentReads
time="2022-08-29T10:09:14Z" level=info msg="Generating TLS certificate {0x7950668 0xc0005a87e0 CN=test-user,POSTALCODE=null,STREET= 2022-08-29 10:10:14.395311361 +0000 UTC [localhost *.localhost] [] 5 []}." common_name=test-user dns_names="[localhost *.localhost]" locality="[]" not_after="2022-08-29 10:10:14.395311361 +0000 UTC" org="[]" org_unit="[]" trace.component=ca
    conn_test.go:177: 
        	Error Trace:	conn_test.go:177
        	Error:      	"messagme" should have 7 item(s), but has 8
        	Test:       	TestPingConnection/ConcurrentReads
        	Messages:   	Wrong message read from connection
=== RUN   TestPingConnection/ConcurrentWrites
panic: Fail in goroutine after TestPingConnection/ConcurrentReads has completed

goroutine 402 [running]:
testing.(*common).Fail(0xc000c40680)
	/opt/go/src/testing/testing.go:817 +0x19b
testing.(*common).Errorf(0xc000c40680, {0x4545f4a, 0x3}, {0xc00022a520, 0x1, 0x1})
	/opt/go/src/testing/testing.go:934 +0xa7
github.com/stretchr/testify/assert.Fail({0x7fae8b04cef0, 0xc000c40680}, {0x45a87ed, 0x22}, {0xc000b41fa8, 0x1, 0x1})
	/go/pkg/mod/github.com/stretchr/testify@v1.7.1/assert/assertions.go:262 +0x429
github.com/stretchr/testify/require.Fail({0x5695a60, 0xc000c40680}, {0x45a87ed, 0x22}, {0xc000b41fa8, 0x1, 0x1})
	/go/pkg/mod/github.com/stretchr/testify@v1.7.1/require/require.go:412 +0xa5
github.com/gravitational/teleport/lib/srv/alpnproxy.TestPingConnection.func2.2()
	/workspace/lib/srv/alpnproxy/conn_test.go:156 +0x1f2
created by github.com/gravitational/teleport/lib/srv/alpnproxy.TestPingConnection.func2
	/workspace/lib/srv/alpnproxy/conn_test.go:151 +0x346
FAIL	github.com/gravitational/teleport/lib/srv/alpnproxy	13.412s
===================================================
@nklaassen
Copy link
Contributor

@zmb3
Copy link
Collaborator

zmb3 commented Aug 29, 2022

See also #15867 which appears to have been fixed.

@ibeckermayer
Copy link
Contributor

Hit a failure here but this time it looks different

        --- FAIL: TestPingConnection/BufferSize/Short (5.00s)
        	Messages:   	2 connections remaining
        	Test:       	TestPingConnection/BufferSize/Short
        	Error:      	failed waiting for TLS connections
        	            				/workspace/lib/srv/alpnproxy/conn_test.go:45
        	            				/workspace/lib/srv/alpnproxy/conn_test.go:274
        	Error Trace:	/workspace/lib/srv/alpnproxy/conn_test.go:364
    conn_test.go:364: 

@ibeckermayer ibeckermayer reopened this Oct 31, 2022
@smallinsky
Copy link
Contributor

Should be fixed by #15969

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants