Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tsh starts the browser with the login flow many times in parallel #16534

Closed
fungiboletus opened this issue Sep 20, 2022 · 3 comments · Fixed by #26102
Closed

tsh starts the browser with the login flow many times in parallel #16534

fungiboletus opened this issue Sep 20, 2022 · 3 comments · Fixed by #26102
Labels
bug good-starter-issue Good starter issue to start contributing to Teleport tsh tsh - Teleport's command line tool for logging into nodes running Teleport.

Comments

@fungiboletus
Copy link

Expected behavior:
Running tsh on an expired session many times in parallel should not open a browser many times and corrupt the tsh state.

Current behavior:
When I start VSCode with the Kubernetes plugin on an expired session, tsh starts my web browser 3 times in parallel. This cause potential race conditions. See #16494.

Bug details:

  • Teleport version 10.2.2
  • Recreation steps Start tsh many times in parallel on an expired session.
  • Debug logs N/A
@zmb3 zmb3 added the tsh tsh - Teleport's command line tool for logging into nodes running Teleport. label Sep 20, 2022
@zmb3 zmb3 added the good-starter-issue Good starter issue to start contributing to Teleport label Dec 4, 2022
@ICHx
Copy link

ICHx commented Jan 12, 2023

I have the same issue, from pycharm as well as, vscode when opening any yaml file.

@fungiboletus
Copy link
Author

image

A new record of parallel login flows in my web browser 😄

@webvictim
Copy link
Contributor

Fixed by #26102

@webvictim webvictim linked a pull request May 31, 2023 that will close this issue
Add kube credentials lockfile to prevent possibility of excessive login attempts #26102
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good-starter-issue Good starter issue to start contributing to Teleport tsh tsh - Teleport's command line tool for logging into nodes running Teleport.
Projects
None yet
Milestone
No milestone
4 participants
@fungiboletus @webvictim @zmb3 @ICHx