Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement in-app logic for a deep link to Connect My Computer #32188

Closed
4 of 5 tasks
Tracked by #32185
ravicious opened this issue Sep 20, 2023 · 0 comments · Fixed by #33964
Closed
4 of 5 tasks
Tracked by #32185

Implement in-app logic for a deep link to Connect My Computer #32188

ravicious opened this issue Sep 20, 2023 · 0 comments · Fixed by #33964
Labels
teleport-connect Issues related to Teleport Connect.

Comments

@ravicious
Copy link
Member

ravicious commented Sep 20, 2023

TODO:

  • Read custom URL from event / app start.
    • Since the custom URI is always passed as the first command-line arg, look for it at a specific position rather than scanning through all argv items.
  • Check how URL encoding works in different browsers.
    • "Another behavior to be aware of is that some callers will decode or encode URLs before passing them along to the target program." source, test website
    • Check @ and other signs that are likely to be included in cluster addresses and usernames.
  • Parse it / validate it with whatwg-url.
    • Check if it matches the protocol.
    • Check if the pathname matches any of the supported URIs.
    • Extract and pass just the pathname + query string (our URI).
  • Pass it to the frontend app.
  • Implement flow in the frontend app after receiving the custom protocol event.

Buttons for testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
teleport-connect Issues related to Teleport Connect.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants