Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session is not recorded when leaf cluster is in proxy recording mode but root cluster is not #3894

Open
russjones opened this issue Jun 24, 2020 · 6 comments

Comments

@russjones
Copy link
Contributor

If I use tsh ssh --cluster=leaf.com server01, I can't see the list of sessions in either the Web UI or use tsh play to play the session. I suspect this is not due to a bug in the Web UI, but the backend since it doesn't work from tsh either. However the Web UI does show an interesting showing 1 out of 0 message.

$ tsh play --cluster=leaf.com 4a4649a0-b5bd-4b0f-b194-5a3158d5696d
error: 0 not found

image

@russjones russjones added this to the 4.3 "Oceanside" milestone Jun 24, 2020
@awly awly self-assigned this Jun 24, 2020
@russjones
Copy link
Contributor Author

The error error: 0 not found may be a bit misleading since I got the session ID was from the output of env. Maybe it should be checked on the backend.

@awly
Copy link
Contributor

awly commented Jun 25, 2020

@russjones not able to reproduce this on master.
I can playback the session via tsh play and I see it in web UI under the matching cluster. Leaf sessions don't show up in root cluster's audit log.

Was there something else special about your setup? Which backend did it use?

@webvictim
Copy link
Contributor

I just ran into the 0 not found error when trying to run tsh play with a session ID that's off by one. We should fix this error to be more descriptive.

@awly
Copy link
Contributor

awly commented Jun 26, 2020

OK, looks like sessions recordings are not working in proxy recording mode.
I'll investigate that and fix the error message along the way.

@awly awly changed the title Can't view or play session in remote cluster. Session is not recorded when leaf cluster is in proxy recording mode but root cluster is not Jun 26, 2020
@awly
Copy link
Contributor

awly commented Jun 26, 2020

Talked to @russjones.
The problem is that leaf proxy was in proxy recording mode and root wasn't.
Because of how the leaf proxy handles requests from the reverse tunnel, it doesn't even check that it's supposed to be recording.

The cleanest solution would be to teach leaf proxies to record sessions coming over the reverse tunnel.

@russjones
Copy link
Contributor Author

Best: 2
Worst: 4

@awly awly removed their assignment Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants