Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: https://raw.githubusercontent.com/gravitl/netmaker/master/scripts/nm-certs.sh is missing #2790

Closed
1 task done
PavelNiedoba opened this issue Jan 23, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@PavelNiedoba
Copy link

Contact Details

No response

What happened?

Official documentation https://netmaker.readthedocs.io/en/master/quick-start.html mention https://raw.githubusercontent.com/gravitl/netmaker/master/scripts/nm-certs.sh file, but it's missing. Therefore netmaker cannot be installed.

Also the installation expect to be in /root folder, which is discouraged.

Certificates should be generated inside container automatically.

Version

v0.22.0

What OS are you using?

Linux

Relevant log output

root@vm-vpn:~# wget https://raw.githubusercontent.com/gravitl/netmaker/master/scripts/nm-certs.sh
--2024-01-23 19:12:15--  https://raw.githubusercontent.com/gravitl/netmaker/master/scripts/nm-certs.sh
Resolving raw.githubusercontent.com (raw.githubusercontent.com)... 185.199.111.133, 185.199.108.133, 185.199.109.133, ...
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|185.199.111.133|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2024-01-23 19:12:15 ERROR 404: Not Found.

Contributing guidelines

  • Yes, I did.
@PavelNiedoba PavelNiedoba added the bug Something isn't working label Jan 23, 2024
@abhishek9686
Copy link
Member

nm-certs has been deprecated using this cmd to install netmaker sudo wget -qO /root/nm-quick.sh https://raw.githubusercontent.com/gravitl/netmaker/master/scripts/nm-quick.sh && sudo chmod +x /root/nm-quick.sh && sudo /root/nm-quick.sh

@PavelNiedoba
Copy link
Author

I believe it's still bug, because https://netmaker.readthedocs.io/en/master/quick-start.html is obsolete and should be updated

@pquan
Copy link

pquan commented Feb 27, 2024

This issue also affects the nm-upgrade.sh script.
The script will wget https://raw.githubusercontent.com/gravitl/netmaker/v0.22.0/scripts/nm-certs.sh and fail.
Bash will exit due to error and the whole upgrade process stops in an inconsistent state (no env created etc).

@abhishek9686
Copy link
Member

This issue also affects the nm-upgrade.sh script. The script will wget https://raw.githubusercontent.com/gravitl/netmaker/v0.22.0/scripts/nm-certs.sh and fail. Bash will exit due to error and the whole upgrade process stops in an inconsistent state (no env created etc).

from which version are you trying to upgrade from?

@pquan
Copy link

pquan commented Feb 27, 2024

Upgrading from 0.17.1 as per instructions. This is a very old install but upgraded to 0.17.1 and working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants