Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File type images #26

Closed
dominicrann61 opened this issue Jun 13, 2019 · 3 comments
Closed

File type images #26

dominicrann61 opened this issue Jun 13, 2019 · 3 comments
Assignees
@marc2332
Labels
enhancement New feature or request

Comments

@dominicrann61
Copy link
Contributor

Hi,
I have noticed that some file types don't have icons.
This is prob not major but as the editor grows may be something to consider.

Thanks
@marc2332 marc2332 self-assigned this Jun 13, 2019
@marc2332
Copy link
Member

That's right, I have to make more

@marc2332 marc2332 added the enhancement New feature or request label Jun 13, 2019
@bailycase
Copy link

Might be worth having a fallback icon as well. If icons cannot be loaded for a specific file type, then we still have a icon.

@marc2332
Copy link
Member

Hello Baily,

That is what Graviton does, example:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marc2332 marc2332

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bailycase @marc2332 @dominicrann61