fix(CodeBlock): Fixed code insert #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makhnatkin
force-pushed
the
fix-code-insert
branch
from
b7ef5ff
to
8d4d63a
Compare
|
Preview is ready. |
d3m1d0v
reviewed
May 31, 2024
| const getLangOfNode = (node: Element) => { | ||
| return ( | ||
| node.getAttribute(CodeBlockNodeAttr.Lang) || | ||
| node.firstElementChild?.getAttribute('class')?.split(' ')?.[1] || |
There was a problem hiding this comment.
Let's add additional checks that firstElementChild is <code/> element, it has hljs classname, etc ?
d3m1d0v
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inserting a copied block of code from the preview, the language is correctly set, provided that it was previously set.