feat: add g-md-editor classname to editor dom elem, change default prefix for internal classnames #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efix for internal classnames
|
Preview is ready. |
makhnatkin
reviewed
Jun 3, 2024
| @@ -3,8 +3,8 @@ | |||
| $selection-color: rgba(98, 146, 255, 0.2); | |||
| $toolbar-height: 28px; | |||
|
|
|||
| .ye-markup-editor, | |||
| .ye-markup-preview { | |||
| .g-md-markup-editor, | |||
There was a problem hiding this comment.
question (not blocks):
What is the reasoning behind choosing a class name and what does g- stand for? Is this consistent with the Gravity UI?
There was a problem hiding this comment.
yes, g-md- its short for Gravity Markdown Editor
| @@ -1,3 +1,3 @@ | |||
| .yfm-cut-title .ye-yfm-cut-title-inner { | |||
| .yfm-cut-title .g-md-yfm-cut-title-inner { | |||
There was a problem hiding this comment.
question (not blocks):
.yfm-cut-title is is correct?
There was a problem hiding this comment.
yes, this css selector is correct
| @@ -17,7 +17,7 @@ export const YfmDist: ExtensionAuto = (builder) => { | |||
| new Plugin({ | |||
| props: { | |||
| attributes: { | |||
| class: 'yfm yfm_no-list-reset', | |||
| class: 'yfm yfm_no-list-reset yfm-editor', | |||
There was a problem hiding this comment.
for backward compatibility, as some services use this class name to override styles in markdown content in editor
makhnatkin
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yfm-editor->g-md-editoryfm-editorclassname to editor inYfmDistextensionye-->g-md-) when creating class names using helper fromsrc/classname--ye-toolbar-sticky-offset––>--g-md-toolbar-sticky-offset--ye-math-back-color––>--g-md-math-back-color--ye-math-hover-color––>--g-md-math-hover-color