feat(ImageCard): add contentPosition #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DC-RomanKarpov
commented
Apr 10, 2024
DC-RomanKarpov
commented
- generalize contentPosition behavior for all cards
+ generalize contentPosition behavior for all cards
|
Playwright Test Component is ready. |
|
Preview is ready. |
NikitaCG
requested changes
Apr 15, 2024
| @@ -15,7 +15,7 @@ import './LayoutItem.scss'; | |||
| const b = block('layout-item'); | |||
|
|
|||
| const LayoutItem = ({ | |||
| content: {links, buttons, ...content}, | |||
There was a problem hiding this comment.
why are we removing the buttons?
There was a problem hiding this comment.
Because we pass them to the Content component directly. We do not make any transformations with them like with links.
NikitaCG
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.