Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop rendering for waterway=wadi #1365

Closed
matkoniecz opened this issue Mar 11, 2015 · 11 comments · Fixed by #3931
Closed

drop rendering for waterway=wadi #1365

matkoniecz opened this issue Mar 11, 2015 · 11 comments · Fixed by #3931

Comments

@matkoniecz
Copy link
Contributor

As discussed on tagging mailing list[a] and described on wiki[b] this tag is ambiguous. It may mean ephemeral river, valley, typical course of flash floods. What worse word wadi is used in multiple languages with multiple meanings. There are also additional problems.

It is recommended to use waterway=river/waterway=stream + intermittent=yes for waterways, natural=valley for valleys.

I am proposing to drop rendering of this tag.

[a] https://lists.openstreetmap.org/pipermail/tagging/2015-January/thread.html - thread "waterway=wadi problem"
[b] http://wiki.openstreetmap.org/wiki/Tag:waterway%3Dwadi

@dieterdreist
Copy link

Am 11.03.2015 um 17:24 schrieb Mateusz Konieczny notifications@github.com:

It may mean ephemeral river, valley, typical course of flash floods. What worse word wadi is used in multiple languages with multiple meanings. There are also additional problems.

It is recommended to use waterway=river/waterway=stream + intermittent=yes for waterways, natural=valley for valleys.

I am proposing to drop rendering of this tag.

I agree that the tagging you propose is more generic and might be universally applicable for similar features, but I don't agree that the meaning in Arabic (valley) is a problem, there has been a definition in the wiki, and the key waterway does give enough context not to apply this tag to valleys

cheers,
Martin

@pnorman
Copy link
Collaborator

pnorman commented Mar 12, 2015

As discussed on tagging mailing list[a] and described on wiki[b] this tag is ambiguous. It may mean ephemeral river, valley, typical course of flash floods. What worse word wadi is used in multiple languages with multiple meanings. There are also additional problems.

It is recommended to use waterway=river/waterway=stream + intermittent=yes for waterways, natural=valley for valleys.

I am proposing to drop rendering of this tag.

It sounds like the tagging change and rendering change are occurring in the wrong order

@matthijsmelissen
Copy link
Collaborator

It sounds like the tagging change and rendering change are occurring in the wrong order

I agree.

@matkoniecz
Copy link
Contributor Author

What would be a good point to drop rendering? Used less than 1k times? Currently it is used 18 343 times - http://taginfo.openstreetmap.org/tags/waterway=wadi

@sommerluk
Copy link
Collaborator

Now 11 170 ways with this tag.

@sommerluk
Copy link
Collaborator

Down to 6253 usages on ways now.

@imagico
Copy link
Collaborator

imagico commented Feb 16, 2019

Reopening since:

  • use is now about 1/3 of what it was when the issue was closed
  • the tag has been deprecated for several years now
  • there is very little active use of the tag, most remaining occurrences are from edits at least several years old, in particular three groups from individual mappers in Tunisia, Pakistan and southern Turkey from about 4 years ago account for nearly half of the data.

@imagico imagico reopened this Feb 16, 2019
@imagico imagico removed the declined label Feb 16, 2019
@polarbearing
Copy link
Contributor

+1 for dropping.
Maybe the PL wiki page could be changed to use the proper Deprecated template, instead of "description=Do not use, see the wiki page".

@sommerluk
Copy link
Collaborator

+1 for dropping

If the feature is ambiguous and can mean two different things, the rendering will always be bad for at least one the these two meaning.

@pnorman
Copy link
Collaborator

pnorman commented Feb 17, 2019

in particular three groups from individual mappers in Tunisia, Pakistan and southern Turkey from about 4 years ago account for nearly half of the data.

This is the most compelling part for me.

@jeisenbe
Copy link
Collaborator

Usage chart:

waterway-wadi-taghistory

Compare to intermittent=yes used over 2 million times on waterway features, including 1.9 million intermittent streams alone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants