Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tourism=attraction is selected too early in COALESCE #1371

Closed
matkoniecz opened this issue Mar 14, 2015 · 1 comment
Closed

tourism=attraction is selected too early in COALESCE #1371

matkoniecz opened this issue Mar 14, 2015 · 1 comment

Comments

@matkoniecz
Copy link
Contributor

After #1349 [landuse=; tourism=attraction; name=] label is rendered in tourism attraction style. Old rendering in that case was better.

landuse village_green tourism attraction name eeeeee eeeeee eeeeee ref 1 ele 8000 closed_way v2 28 1 - master
https://cloud.githubusercontent.com/assets/899988/6650786/b575c936-ca24-11e4-93fe-d3c470635102.png) - see z14 to z17
https://cloud.githubusercontent.com/assets/899988/6650789/b85cbcf4-ca24-11e4-80d2-9312f0e489f9.png - see z15+

It may be solved by splitting COALESCE for tourism key in two parts. Remove value attraction from the current one and add new at the end containing only value attraction. It would reduce priority of tourism=attraction.

'tourism_' || CASE WHEN tourism IN ('attraction')

tourism=attraction overrides also values of other keys COALESCE, except key aeroway.

@matkoniecz
Copy link
Contributor Author

tourism=attraction overrides also values of other keys COALESCE, except key aeroway.

And for features with icons it seems to result in disappearing labels, as tourism=attraction labels is lacking text-dy.

https://cloud.githubusercontent.com/assets/899988/6650842/78f029fa-ca26-11e4-94ea-467b5d4ed202.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant