Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Water parks areas should be rendered #1490

Closed
daganzdaanda opened this issue Apr 17, 2015 · 13 comments · Fixed by #3843
Closed

Water parks areas should be rendered #1490

daganzdaanda opened this issue Apr 17, 2015 · 13 comments · Fixed by #3843

Comments

@daganzdaanda
Copy link

Issue #370 was closed by pull #725, where leisure=water_park got an icon. I think it should also get a fill.
Possible colours:

  • like landuse=meadow (since there are often meadows along the pools)
  • something like sports_centre (maybe rethink that strong green at the same time...)
@mboeringa
Copy link

I don't think this should have a fill, but some kind of outline only. It is a kind of "administrative" border, not a visible feature on the ground (In my personal ArcGIS Renderer, I render it as such: with just an outline). And yes, this is similar for sports_centres and many other OSM features...

@matkoniecz
Copy link
Contributor

@daganzdaanda

Can you give an example of location where fill would be useful?

@mboeringa
Copy link

@matkoniecz: Here is an example rendering of a waterpark in Paris to show you why I think using an outline may be more appropriate. As you can see, there is other stuff being tagged within the outline of the waterpark. Setting a fill could only be done if it is one of the "lower" layers, drawn below most other stuff, but I think an outline is probably best, like with leisure = marina or tourism = theme_park. These features can be quite big as well.

waterpark

@daganzdaanda
Copy link
Author

Can you give an example of location where fill would be useful?

https://www.openstreetmap.org/way/70234702 used to be a leisure=water_park, and someone turned it into leisure=park, probably because it makes the area visible (as someone speculated in a note about it).
Here http://www.openstreetmap.org/way/127430479 there's also "surface=grass" tagged, which doesn't help to make the area green (anymore?), and is actually wrong since the area also contains buildings and the pools...
Checking overpass for water_parks shows a lot of them that look "wrong" because there is nothing to show the extent of them.

But I do agree with @mboeringa that an outline could do the same as a fill, or even more since then people might start to fill the outline with micromapped meadows and trees and so on.

@KaiRo-at
Copy link

I've seen water parks getting a landuse=recreation_ground just so that it gets rendered as green on the map (given that most of the surface is usually grass and recreational stuff is mostly green in our scheme, that color sounds right anyhow).
Examples are http://www.openstreetmap.org/way/24443459 or http://www.openstreetmap.org/way/24444267 around my home town.

@kocio-pl
Copy link
Collaborator

+1 for the outline.

( Another +1 for lighter shade of green in sports_centre - new issue probably? )

@polarbearing
Copy link
Contributor

A water park is a theme park which theme is water, thus treating it the same as a theme park seems logical. Either with the same colour, or more blueish like the marina.

@Tomasz-W
Copy link

Related to #3045

@polarbearing
Copy link
Contributor

Still prefer an outline over a fill.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Aug 6, 2018

I think theme park rendering would be OK. Anybody like to create the PR?

@geozeisig
Copy link

An outline is good and a fill too, but water park got an misleading icon. It shows a swimmer although water parks are not suitable for swimming. So delete the icon or replace it with a better one. The icon should be used for sport facilities #2018.

@johsin18
Copy link
Contributor

johsin18 commented Aug 7, 2018

Thanks to your comments, I came to the conclusion that for my use case, I should rather use leisure=sports_centre, which has a fill already. So please ignore my comment, sorry (I will remove it).

@jeisenbe
Copy link
Collaborator

In #3748, we tried rendering with the tourism (zoo, theme park) outline, but this showed problems: the tag leisure=water_park is often used for swimming pool areas that are not very similar to theme parks. So now the option is to try a fill color, perhaps similar to recreation ground or sports_centre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment