Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

railway=tram is visible from z8, tram is too visible at z13, z15, z16 #1637

Closed
matkoniecz opened this issue Jul 7, 2015 · 3 comments · Fixed by #1638
Closed

railway=tram is visible from z8, tram is too visible at z13, z15, z16 #1637

matkoniecz opened this issue Jul 7, 2015 · 3 comments · Fixed by #1638

Comments

@matkoniecz
Copy link
Contributor

During reworking road style I decided to try changing closely related tram style as on z13, z15, z16 it is really strong.

During more close checking of rendering I discovered that tram tracks are rendered also on z10, z11 and z12 what was quite surprising as I never noticed it.

On reading code I discovered that railway=tram is rendered from z8, what makes no sense. Especially with current style as even during looking for tram lines at known positions I failed to notice it.

Overall this contributes to really bad rendering of cities around z10.

Even in Toronto, city with "the largest streetcar system in the Americas"[1] and quite far on the north (relevant due to distortion of scale) it makes sense to render trams up to z11 - and probably z12 would be more than enough. See http://overpass-turbo.eu/s/ai3 (I linked overpass turbo, as in current rendering tram lines are not possible to find - despite rendering them).

Other example, Vienna - "With 173.4 km of track, Vienna's network is one of the largest in the world."[2] z11 is the lowest zlwevel where rendering tram makes sense ( http://overpass-turbo.eu/s/ai4 - note, query returns large amount of data).

In general it seems that even with large networks rendering tram up to z12 makes sense, z11 may be justified but it is not the best idea but later it is pointless.

My original reason to start tweaking trams is not so clearly justified - but I am convinced that at z13, z15, z16 tram lines are too visible. See for example

selection_001

I propose to make tram lines visible at z12 (darker colour), slightly reduce widths at z13, z15, z16 and remove it completely from zlevels 8 to 11.

I think that it makes sense to make PR for this independent from the giant "rework entire road styling" as merge conflicts are highly unlikely and current tram line rendering is causing the same problems with current road style, proposed new road style and its variants.

The current code:

    [feature = 'railway_tram'] {
      [zoom >= 8] {
        line-color: #ccc;
        [zoom >= 10] { line-color: #aaa; }
        [zoom >= 13] { line-color: #444; }
        line-width: 1;
        [zoom >= 15] {
          line-width: 2;
        }
        .tunnels-fill {
          line-dasharray: 5,3;
        }
      }
    }

[1] https://en.wikipedia.org/wiki/Tram_and_light_rail_transit_systems
[2] https://en.wikipedia.org/wiki/Trams_in_Europe

@matkoniecz matkoniecz changed the title railway tram is visible from z8, tram is too visible at z13, z15, z16 railway=tram is visible from z8, tram is too visible at z13, z15, z16 Jul 7, 2015
@matkoniecz matkoniecz self-assigned this Jul 7, 2015
@kocio-pl
Copy link
Collaborator

kocio-pl commented Jul 7, 2015

I think you're right in general, but I wonder if nobody will complain for using different colors on different zoom levels for the same objects?

@matkoniecz
Copy link
Contributor Author

The quoted code is current one, not the proposed. EDIT: I edited top comment to make it clear.

@daganzdaanda
Copy link

Good changes. Now one can actually use z12 to plan a trip through a city!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants