Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label color for private parking is non-intuitive #2170

Closed
imagico opened this issue Jun 15, 2016 · 5 comments
Closed

Label color for private parking is non-intuitive #2170

imagico opened this issue Jun 15, 2016 · 5 comments

Comments

@imagico
Copy link
Collaborator

imagico commented Jun 15, 2016

Especially when the corresponding symbol is not rendered above the yellow parking color - like here:

http://www.openstreetmap.org/#map=19/50.04516/8.54655

Should IMO be a lighter version of the normal label color, not a greener tone.

@jragusa
Copy link
Contributor

jragusa commented Feb 23, 2018

I recently noticed this issue.

Why not use the key text-opacity to resolve this issue instead of hardcoded the colour ?

@polarbearing
Copy link
Contributor

@transportation-text: #0066ff;
@transportation-icon: #0092da;

The icon uses marker-opacity: 0.33;
The text uses text-fill: @transportation-text; when public
and text-fill: #66ccaf; when private.

not consistent indeed.

@jragusa - are you going to show us test rendering with your proposal?

@jragusa
Copy link
Contributor

jragusa commented Feb 23, 2018

Yes, I'm preparing this

@jragusa
Copy link
Contributor

jragusa commented Feb 23, 2018

And voilà :
before (z=19)
before
after (z=19)
after
I only replaced text-fill: #66ccaf; by text-opacity: 0.33; As you can see, this reduces the readability of the name. With the original setting, the name seems also slightly bigger. Any suggestions ?

@kocio-pl
Copy link
Collaborator

Since this is a private feature, details like name are not that important anyway, so I vote for this change. Could you prepare a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants