-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render non-building shop=mall like landuse=retail #2702
Comments
Sounds reasonable to me when talking about area with this tag. |
Some mapper will drop tagging landuse. |
As said in #2700, rendering the landuse should be sufficient. |
sent from a phone
On 24. Jul 2017, at 00:07, Holger Jeromin ***@***.***> wrote:
Some mapper will drop tagging landuse.
Is that a good thing?
landuse here is kind of superfluous anyway, a shopping mall implies retail landuse
|
I would expect such shop=mall to be part of landuse=retail. Is there an example of correctly mapped place, with mapped landuse that would benefit from this change? |
Of the ~36k ways with shop=mall about 23k have a building tag and about 1.5k have a landuse=retail tag. A few examples of such cases: https://www.openstreetmap.org/way/279460081 These are just random examples - and as said in the initial comment global distribution of such cases is quite strongly tied to climate obviously. Prophylactically: Please don't start a tagging discussion out of this here - any discussion on what is good and bad mapping in this context belongs in other places. |
Did somebody ask about proper using of |
I'd like to submit a PR to fix this issue. The simplest option is to render The other option is to use only an outline. This is the solution that was used for Most shop=mall are also tagged as a building. Rarely there are underground malls; these probably should not be rendered with a fill (or even an outline?) There are a small number that are mapped as an area around the whole mall area and lack landuse=retail; these will be affected by the change. Taginfo isn't quite right because most of the retail areas are mapped as separate features: https://taginfo.openstreetmap.org/tags/?key=shop&value=mall#combinations In that case, Thoughts on fill vs outline, and if location=underground should be excluded from the outline / fill rendering? |
Diamond Run Mall, Vermont. https://www.openstreetmap.org/#map=18/43.58108/-72.96442 The main building is tagged shop=mall but the whole area including parking lots and service roads is also mapped as shop=mall without landuse. Rendering without fill or outline (with PR #3760 to restore the text labels) Add outline only (z16 and higher) - same outline as used on landuse=retail, but without fill |
The one issue is underground malls. Usually these should be tagged Singapore, Raffle's PlaceLabel only rendering(similar to current rendering and if location=underground is excluded) z18 - (text label is blocked by amenity icons) With retail-color fillz16 - just visible (remember, this zoom level in Singapore is similar to z15 in northern Europe) With outline onlyThicker double-outline
Singapore, Downtownhttps://www.openstreetmap.org/#map=18/1.29233/103.85458 Text labels onlyFill colorOutline (double)Perhaps it's best not to these underground features in the landcover layer? |
I would prefer a fill for all malls, regardless of someone having added retail landuse or not.
|
The fill certainly looks better than the outline. A doubled outline looks ok for areas where there is no other landcover, and does show the extent of the geometry in the database: Double outlineDiamond Run Mall, Vermont. https://www.openstreetmap.org/#map=18/43.58108/-72.96442 But it is hard to see when parking lots, grass area or other landcovers are mapped: Sicilia Outlet Village https://www.openstreetmap.org/#map=17/37.573296/14.480978 Fill colorThis looks better in most cases where it makes a difference: |
I'm going with the fill, and not rendering underground malls for now. |
Based on discussion in #2700 we could consider rendering shop=mall like landuse=retail in case it is used on features without a building tag and has no landuse tag. This would essentially affect malls that contain outdoor areas (which is not uncommon in countries with appropriate climate).
It would improve mapper feedback because you would see the mall as mapped independent of labels meaning there would be feedback on accuracy of the geometry.
This would probably only affect about 10 percent of the malls currently mapped - others have a building or a landuse tag.
The text was updated successfully, but these errors were encountered: