Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render non-building shop=mall like landuse=retail #2702

Closed
imagico opened this issue Jul 23, 2017 · 13 comments · Fixed by #3790
Closed

Render non-building shop=mall like landuse=retail #2702

imagico opened this issue Jul 23, 2017 · 13 comments · Fixed by #3790

Comments

@imagico
Copy link
Collaborator

imagico commented Jul 23, 2017

Based on discussion in #2700 we could consider rendering shop=mall like landuse=retail in case it is used on features without a building tag and has no landuse tag. This would essentially affect malls that contain outdoor areas (which is not uncommon in countries with appropriate climate).

It would improve mapper feedback because you would see the mall as mapped independent of labels meaning there would be feedback on accuracy of the geometry.

This would probably only affect about 10 percent of the malls currently mapped - others have a building or a landuse tag.

@kocio-pl
Copy link
Collaborator

Sounds reasonable to me when talking about area with this tag.

@HolgerJeromin
Copy link
Contributor

Some mapper will drop tagging landuse.
Is that a good thing?

@polarbearing
Copy link
Contributor

As said in #2700, rendering the landuse should be sufficient.

@dieterdreist
Copy link

dieterdreist commented Jul 24, 2017 via email

@matkoniecz
Copy link
Contributor

I would expect such shop=mall to be part of landuse=retail. Is there an example of correctly mapped place, with mapped landuse that would benefit from this change?

@imagico
Copy link
Collaborator Author

imagico commented Jan 5, 2018

Of the ~36k ways with shop=mall about 23k have a building tag and about 1.5k have a landuse=retail tag.

A few examples of such cases:

https://www.openstreetmap.org/way/279460081
https://www.openstreetmap.org/way/363949116
https://www.openstreetmap.org/way/100853666
https://www.openstreetmap.org/way/24516528
https://www.openstreetmap.org/way/24690224
https://www.openstreetmap.org/way/179229712
https://www.openstreetmap.org/way/68674783

These are just random examples - and as said in the initial comment global distribution of such cases is quite strongly tied to climate obviously.

Prophylactically: Please don't start a tagging discussion out of this here - any discussion on what is good and bad mapping in this context belongs in other places.

@Tomasz-W
Copy link

Did somebody ask about proper using of shop=mall on Tagging list?

@jeisenbe
Copy link
Collaborator

I'd like to submit a PR to fix this issue. The simplest option is to render shop=mall with the same color fill and outline as landuse=retail and amenity=marketplace.

The other option is to use only an outline. This is the solution that was used for man_made_works, since it was agreed that these areas should also be tagged landuse=industrial (or be included within a large industrial landuse area). The wiki page for shop=mall mentions using landuse=retail https://wiki.openstreetmap.org/wiki/Tag:shop=mall

Most shop=mall are also tagged as a building. Rarely there are underground malls; these probably should not be rendered with a fill (or even an outline?) There are a small number that are mapped as an area around the whole mall area and lack landuse=retail; these will be affected by the change. Taginfo isn't quite right because most of the retail areas are mapped as separate features: https://taginfo.openstreetmap.org/tags/?key=shop&value=mall#combinations

In that case, amenity=marketplace could also be changed to only have an outline. However, the wiki page does not mention adding landuse=retail so we could also consider this to be implied: https://wiki.openstreetmap.org/wiki/Tag:amenity=marketplace

Thoughts on fill vs outline, and if location=underground should be excluded from the outline / fill rendering?
And should the text label be shown for shop=mall with location underground?

@jeisenbe
Copy link
Collaborator

Diamond Run Mall, Vermont. https://www.openstreetmap.org/#map=18/43.58108/-72.96442

The main building is tagged shop=mall but the whole area including parking lots and service roads is also mapped as shop=mall without landuse.

Rendering without fill or outline (with PR #3760 to restore the text labels)
z17
z17-diamond-run-mall-fixed

Add outline only (z16 and higher) - same outline as used on landuse=retail, but without fill
z17
z17-diamond-run-outline

z16
z16-diamond-run-outline

z15
z15-diamond-run-mall-outline

Add fill as well
z17
z17-diamond-run-mall-fill

z15
z15-diamond-run-mall-fill

@jeisenbe
Copy link
Collaborator

The one issue is underground malls. Usually these should be tagged location=underground but I've also found some tagged underground=yes in Singapore, where there are a number of these features. But underground=yes is a rare tag (<700 times), so I think we would only need to check for location=underground, which is well established (>66,000 uses).

Singapore, Raffle's Place

Label only rendering

(similar to current rendering and if location=underground is excluded)
z16
z16-no-fill-underground

z18 - (text label is blocked by amenity icons)
z18-no-underground-malls

With retail-color fill

z16 - just visible (remember, this zoom level in Singapore is similar to z15 in northern Europe)
z16-singapore-downtown-malls-after

z18
z18-marina-bay-mall-underground

z19
z19-marina-bay-link-mall-after-underground

With outline only

z18
z18-mall-underground-outline-only

Thicker double-outline

  • thin line in @retail-line color on top of thicker 2 pixel line offset toward polygon center in @retail fill color

z18-underground-mall-retail-double-outline

Singapore, Downtown

https://www.openstreetmap.org/#map=18/1.29233/103.85458

Text labels only

z17
z17-citylink-label-only

z19
z19-underground-citylink

Fill color

z18
z18-citylink-fill

z19
z19-citylink-fill

Outline (double)

z18
z18-citylink-outline
z19
z19-citylink-outline

Perhaps it's best not to these underground features in the landcover layer?

@dieterdreist
Copy link

dieterdreist commented Apr 23, 2019 via email

@jeisenbe
Copy link
Collaborator

The fill certainly looks better than the outline. A doubled outline looks ok for areas where there is no other landcover, and does show the extent of the geometry in the database:

Double outline

Diamond Run Mall, Vermont. https://www.openstreetmap.org/#map=18/43.58108/-72.96442
z16
z16-diamond-run-double-outline
z17
z17-diamond-run-double-line

But it is hard to see when parking lots, grass area or other landcovers are mapped:
Carrefore Zahira https://www.openstreetmap.org/#map=17/37.89343/-4.74746
z17-zahira-outline-double

Sicilia Outlet Village https://www.openstreetmap.org/#map=17/37.573296/14.480978
z17-sicilia-double-outline

Fill color

This looks better in most cases where it makes a difference:
Diamond Run z17 - see above also
z17-diamond-run-mall-fill

Zahira z17
z17-zahira-after-fill

Sicilia z16
z16-sicilia-outlet-village-fill

z17
z17-sicilia-fill

@jeisenbe
Copy link
Collaborator

I'm going with the fill, and not rendering underground malls for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants