Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering of man_made=breakwater is filled in multipolygons and not in closed ways #2987

Closed
muralito opened this issue Dec 19, 2017 · 3 comments

Comments

@muralito
Copy link

The rendering of man_made=breakwater is filled in multipolygons and not in closed ways.
It can be seen here https://b.tile.openstreetmap.org/15/11455/19749.png
in https://www.openstreetmap.org/#map=15/-34.6513/-54.1438

@mboeringa
Copy link

mboeringa commented Dec 19, 2017

That is because the defaults have changed: closed ways that are not tagged with area=yes, are no longer being treated by default as an area for man_made=breakwater. Since multipolygons by default are areas, this issue does not affect them.

The setting change is because there was a conflict with linear ways of man_made=breakwater, in the sense of ambiguity: is a closed way always an area? No, it could be a circular way (think dikes), that needs to be treated as line object instead of area.

By no longer treating the closed way as an area by default, you can resolve the ambiguity by explicitly setting area=yes on the man_made=breakwater features. It should then render as area again. So that is your solution: set explicit area=yes for all breakwaters that are true areas.

@matthijsmelissen
Copy link
Collaborator

Correct. All tags that can both be areas and lines are always treated as lines now, unless they have an explicit area tag. This is true even if they are closed, to avoid confusion. I doubt circupar breakwaters exist, but behaviour was made the same for all features, for consistency reasons.

@muralito
Copy link
Author

OK .Will document in wiki.

There exist a list of the features that have their default changed so their wiki pages can be updated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants