Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parking fill color is the same as living street fill color #3891

Open
jeisenbe opened this issue Sep 18, 2019 · 13 comments
Open

Parking fill color is the same as living street fill color #3891

jeisenbe opened this issue Sep 18, 2019 · 13 comments

Comments

@jeisenbe
Copy link
Collaborator

Expected behavior

  • Parking lots should be clearly distinguished from living street ways and areas

Actual behavior

  • The newer parking-fill color, #eeeeee is Lch (94,0,180)
  • This is indistinguishable from living-street-fill color, #ededed - also Lch (94,0,180)
  • Only the casing is different
@jeisenbe
Copy link
Collaborator Author

jeisenbe commented Sep 18, 2019

Also, parking-outline still uses saturate(darken but I think the saturate doesn't do anything, since saturation is 0.

@imagico
Copy link
Collaborator

imagico commented Sep 19, 2019

Not as close but there are various other cases where unrelated features are rendered with very similar fill colors. Specifically apron and pedestrian colors are very close now - as well as #2353, #2905.

I am generally not sure if there is agreement among maintainers that differences in fill colors should represent differences in meaning and colors should therefore not be overloaded for unrelated purposes. Similarity to other unrelated color played no role in discussion of most of these changes (#2292, #2934, #3444) and i am not sure if that is because it was being overlooked or if it was considered not to matter when the change was made. We also have cases with a deliberate choice to aggregate things fairly dissimilar in meaning into a common color (#3843 (comment)). From my perspective it comes all back to #2270.

@jeisenbe
Copy link
Collaborator Author

The apron vs pedestrian color similarity appears to have been overlooked in #3444 and the related issue #3385, from what I can see. There was discussion of using the parking color, since aprons are parking areas for aircraft, but then the current color was picked to be a little more visibly related to taxiways.

It doesn't look like there was any discussion of the similarity between the new parking color and living-street-fill in #2934 or #2904 - these things are easy to miss if you don't look for them carefully.

@kocio-pl
Copy link
Collaborator

Could you show real problems with that? I don't remember a single time I had mistaken them.

@jeisenbe
Copy link
Collaborator Author

For some reason highway=living-street areas do not have a casing, unlike highway=pedestrian and highway=residential areas, otherwise they look identical to parking lots:

z15 https://www.openstreetmap.org/#map=14/52.5183/13.1686
z15-parking-vs-living-street-area

Only the parking icon makes it obvious at higher zoom levels (and these can be blocked by other icons, since they are low-priority)

z16
z16-parking-vs-living-street-area

z17
z17-living-street-areas

There are 1877 ways with highway=living_street and area=yes or relations with highway=living_street which will render in this way currently.

This blocks adding a proper casing to highway=living_street areas, since they would then be nearly identical to parking lots.

@jeisenbe
Copy link
Collaborator Author

#eeeeee and #ededed (Lch 94,0,180) are also very close to land-color: #f2efe9 (Lch 95,3,91) - the lightness is only 1 different, and the chroma is only 3 instead of 0. This gives a delta of 3.3. The living street areas look similar to untagged land right now, since there is no casing.

@jeisenbe
Copy link
Collaborator Author

@kocio-pl
Copy link
Collaborator

The only problem I see is Spandau areas example (the first one), so this effect looks very limited to me and I don't believe there are many disconnected areas like this. When areas are connected to the road system, it is totally clear to me that this is not a parking space. There is also interesting case here (near the last example), where parking is connected to a living street line and this is also something that leaves me no doubts:

map(2)

@jeisenbe
Copy link
Collaborator Author

jeisenbe commented Sep 22, 2019 via email

@kocio-pl
Copy link
Collaborator

Sorry if it sounded like rejection, I didn't mean it. Maybe you're right and somebody else could see this problem more clearly. I just provided my review and my conclusion is that it's much smaller issue than I expected.

@pnorman
Copy link
Collaborator

pnorman commented Sep 24, 2019

I think there is a problem with the closeness of colour, but living streets aren't common where I map so I'm not the right person to evaluate what changes make sense.

@danieldegroot2
Copy link
Contributor

danieldegroot2 commented Sep 17, 2023

Something similar happens with building passage. Combined with parking aisle, the service ways almost look disconnected.
(however, our brain allows us to zoom out and see it's supposed to be a continuous line and ignores this detail otherwise.)
https://www.openstreetmap.org/#map=19/52.64812/-7.25142

image

@imagico
Copy link
Collaborator

imagico commented Sep 17, 2023

Yes, this shows that the tunnel fill color of white roads:

@residential-tunnel-fill: darken(@residential-fill, 5%);

is also fairly similar (slightly brighter) compared to both living street fill and parking fill:

road tunnelparkingliving_street

For comparison the AC-style:

road tunnelparkingliving_street

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants