Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change rendering of man_made=embankment and barrier=retaining_wall #4124

Open
valhentai opened this issue Apr 23, 2020 · 4 comments
Open

Change rendering of man_made=embankment and barrier=retaining_wall #4124

valhentai opened this issue Apr 23, 2020 · 4 comments
Labels

Comments

@valhentai
Copy link

valhentai commented Apr 23, 2020

I have some proposition of improvement for the rendering of made_made=embankment and barrier=retaining_wall

  • Use the current rendering of made_made=embankment for barrier=retaining_wall. The current rendering of retaining_wall is the same as a normal wall. The use of the embankment would show that there is a difference of level between the two side of the wall
  • Use the proposed rendering of natural=earth_bank for the made_made=embankment but with a lighter color. The current rendering is similar to rendering used on other map to show a fortified wall or rampart. On the map it give the impression of an impassable barrier but depending on the slope a embankment can be easily crossed.

The proposed rendering is already used in JOSM.
josm embankment

  • If we decide to use the proposed rendering of natural=earth_bank for embankment, maybe render natural=earth_bank too with the same render or different color.

Here an example where i used made_made=embankment. On OSM it look like there is an impassable wall but on the pitcure we can see it is easily climbed.

embankment_street_view

embankment2

Maybe I misuse made_made=embankment and should use natural=earth_bank. For me the two are the same with one natural and one artificial.

@imagico
Copy link
Collaborator

imagico commented Apr 23, 2020

made_made=embankment and barrier=retaining_wall are features with distinct and different practical meaning so rendering them identically does not seem a very good idea.

natural=earth_bank is covered in #2288.

For better differentiating different kind of barriers see also #3975.

For reference: We currently render:

  • natural=cliff
  • made_made=embankment
  • barrier=retaining_wall as a generic barrier

We don't render

Any suggestions for changes should take into account the need for an intuitive understanding of the different features and their semantic relationships.

@valhentai
Copy link
Author

@imagico What i wanted to say was to use the current rendering of made_made=embankment for barrier=retaining_wall and change the rendering of made_made=embankment. Not use the same rendering for the two. My two first proposition can't be separated.

@imagico
Copy link
Collaborator

imagico commented Apr 23, 2020

I got that - and it would be worth trying. What i meant to say is that if you (or someone else) wants to test this idea it is important to see how it relates to the other things that are currently rendered - and possibly also those which are not rendered but we might want to render in the future.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Apr 24, 2020

Previously there was an attempt to make a different rendering for barrier=retaining_wall, in #3714 (comment) e.g.:

(barrier=retaining_wall on the west, otherwise man_made=embankment`)

Retaining wall on west, next to green hedge.

@jeisenbe jeisenbe changed the title Rendering of embankment and retaining wall Change rendering of man_made=embankment and barrier=retaining_wall Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants