Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golf=pin in rendered on nodes and polygons but is only used on nodes #4862

Open
imagico opened this issue Aug 16, 2023 · 2 comments
Open

golf=pin in rendered on nodes and polygons but is only used on nodes #4862

imagico opened this issue Aug 16, 2023 · 2 comments

Comments

@imagico
Copy link
Collaborator

imagico commented Aug 16, 2023

For mapper feedback it would be good to remove rendering of golf=pin on polygons. This is currently not used at all so it is not constructive for us to render.

Just requires adding a way_area IS NULL condition in SQL.

@benjaco
Copy link
Contributor

benjaco commented Aug 16, 2023

Could not find any guidance to test cases where it issn't in the OSM dataset, how do you normally go about testing such things?

@imagico
Copy link
Collaborator Author

imagico commented Aug 16, 2023

You can create a test case in JOSM, run it through osmium renumber and import it into your test database.

Alternatively you can also edit your test database - for example something like:

UPDATE planet_osm_polygon SET tags = tags || '"golf"=>"pin"'::hstore WHERE osm_id = 12345;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants