-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change icons for amenity=waste_disposal
and amenity=waste_basket
#4914
Comments
Thanks for looking at the waste icons. These indeed could use some refinement work. I don't quite understand your critique and suggestion though. Here current symbols we use and the maki waste basket symbol mentioned in comparison:
|
Agree with the general point that From a brief look, it is not straightforward to simply re-use the font awesome icons as iD does. iD can and does use larger icons (16 x 16?) for a start. A simplified version of the font awesome "dumpster" might work. Wide rather than tall would visually differentiate from Personally I don't think the maki wastebasket looks good. It looks like a cup with a generous cappuccino! The FA symbol is more recognisable. |
Expected behavior
amenity=waste_disposal
should be rendered with something similar to a dumpster/large container.amenity=waste_basket
should be rendered with something that looks like a waste basket.Actual behavior
Currently
amenity=waste_disposal
is rendered with the same icon asamenity=waste_basket
but with minor diffrences (one of them being their size).amenity=waste_basket
is rendered using an icon that looks like a cremation pot/flower pot with a lid.iD seems to use nice icons for both of them. I'm not sure if they can be used directly but they are a good inspiration.
amenity=waste_basket
: https://github.com/mapbox/maki/blob/main/icons/waste-basket.svgamenity=waste_disposal
: https://fontawesome.com/v5/icons/dumpster?f=classic&s=solidScreenshots with links illustrating the problem
Current rendering:
iD icons:
The text was updated successfully, but these errors were encountered: