Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render covered=yes on bridges too if they are under a building #930

Closed
rickmastfan67 opened this issue Sep 7, 2014 · 7 comments
Closed

Comments

@rickmastfan67
Copy link

This is separate from #444, hence why I created a new ticket.

I hope that the covered=yes tag rendering can be extended to bridges with said tag. Here's an example of this that needs the special rendering:
https://www.openstreetmap.org/way/54216348

It looks bad, when on each side it's rendered properly. And YES, there really is a bridge there. Here's a link to a view of it in StreetView as I don't have a good personal shot of it (had a really bad camera the last time I was close enough to it that didn't like low light shots at all). http://goo.gl/maps/yocCh

So, would something like this be possible?

@matthijsmelissen
Copy link
Collaborator

Hmm, so this road has basically both aspects of a bridge and a tunnel?

@rickmastfan67
Copy link
Author

Yep.

@mboeringa
Copy link

Here's another nice example, the Tubular Bridge near the historic town of Conwy in North Wales:

http://www.openstreetmap.org/way/240020723

Both bridge, tunnel and roof tagged... correctly:

http://binged.it/1qFMHSi

@mboeringa
Copy link

This is how this particular situation is currently rendered by my OSM Renderer for ArcGIS. Both bridge, tunnel and roof are rendered, and note the spurious "embankment" tag as well that gets rendered on the southern section of the bridge, and must be tagged on this section.

conwy_github_930

@matthijsmelissen matthijsmelissen changed the title Render covered=yes on bridges too if they are under a building. Render covered=yes on bridges too if they are under a building Sep 11, 2014
@matkoniecz matkoniecz modified the milestones: 3.x - Needs upgrade to mapnik or openstreetmap-carto.style, Bugs and improvements Oct 26, 2014
@matthijsmelissen
Copy link
Collaborator

As this is a fairly rare situation, I think it's best to leave this as is. Opinions?

@dieterdreist
Copy link

2014-11-11 2:29 GMT+01:00 math1985 notifications@github.com:

As this is a fairly rare situation, I think it's best to leave this as is.
Opinions?

there are covered bridges (with or without buildings above), e.g. covered
by a roof.
Some examples:
http://en.wikipedia.org/wiki/Worrall_Covered_Bridge#mediaviewer/File:Worrall_Covered_Bridge_East.jpg
http://www.bridges-covered.com/Northeast%20PA.htm
...

@matthijsmelissen
Copy link
Collaborator

I think this situation of roads that are both on a bridge and in a tunnel is so rare that it's not worth making special rendering rules for it. I will therefore close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants