Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Important label blocked by unimportant icon (for example amenity=university vs private parking icon) #964

Open
matkoniecz opened this issue Sep 20, 2014 · 11 comments

Comments

@matkoniecz matkoniecz changed the title Important label blocked by unimportant icon (amenity=university vs private parking icon) Important label blocked by unimportant icon (for example amenity=university vs private parking icon) Sep 20, 2014
@matthijsmelissen
Copy link
Collaborator

Letting the minimum zoomlevel of icons depend on the area size would be a way to solve this, I think.

@matkoniecz
Copy link
Contributor Author

Not sure. Icon of gigantic private parking should disappear under typical label. Also in this example this parking is quite large - not displaying this icon for other similarly sized parkings seems to be a poor idea.

@matkoniecz
Copy link
Contributor Author

@matkoniecz
Copy link
Contributor Author

I propose to move parking icon to .amenity-low-priority layer - it should fix this problem.

@matthijsmelissen
Copy link
Collaborator

This is an issue that is being reported repeatedly, but it's not clear what the best solution is. Does anybody have a suggestion?

@matkoniecz
Copy link
Contributor Author

Move more icons/labels to .amenity-low-priority layer? Or create .amenity-high-priority layer for some labels (university, school)?

Or sort objects by area - I think that it is already done for some features.

@matthijsmelissen
Copy link
Collaborator

Moving icons to low-priority might improve the situation (for parking and playground for example), but some problems will remain. A small shop in a hospital might still block the hospital label for example.

Or sort objects by area

Objects are sorted by area, but that's not sufficient as icons always come before labels.

@HolgerJeromin
Copy link
Contributor

and some things are nodes with no area.

@matkoniecz
Copy link
Contributor Author

@HolgerJeromin

some things are nodes with no area

What indicates low importance. And in areas where mapping is just starting and universities are mapped as nodes it is unlikely that there are big problem with high feature density.

@kocio-pl
Copy link
Collaborator

I think this is more general problem: on high zoom levels I'm expecting to see all the small features, while when zooming out I expect to loose details and see only bigger objects.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Mar 24, 2019

I believe this problem still exists because all icons from amenity-points are rendered before text-poly and other text labels. This means that if there is any feature with an icon rendered, such as a parking lot or a drinking fountain, it will block the text label for a large feature, such as a University.

This also happens with features that are rendered with both an icon and a label. In that case, and important text label may be blocked by another minor feature located just south of the important feature.

This might be resolved by creating a new layer for important text labels which would render before all icons, or by merging the amenity point and text layers and using a priority ranking list to determine rendering order for icons and text together, but it would be difficult to get the priority right.

(BTW, does anyone know of an issue that describes this problem more generally? I think we've discussed in comments on other issues as well. Related issues include #1026 - where it is mentioned that some text labels disappear or reappear when zooming in)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants