Version 1.21.5.3 #908
Merged
Version 1.21.5.3 #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since WordPress 4.8 the preview is generated via a REST API call to the oembed/proxy endpoint, which in turn does a remote request to a registered oEmbed provider. The default oEmbed provider fetches the content of a local URL, which, for a GravityView entry URL, ends up being the View instead of the Entry. Register the simplest provider for entry requests and serve the entry as needed.
If a form is trashed the view that connects to it will fatal. Fix this quickly.
@jakejackson1 can you apply this and see if it works for your case? Not sure why it would, but this now uses the `admin_init` hook they show in the EDDSL sample. Related to #896
For now, just log an error. Closes #905
These errors were an edge case, migrating the `{prefix}_options` table,
but it's possible that others could have this affect them, too.
Fixes #907
When saving a custom field, our code will load the value of the saved field back into the entry. For later versions of GF the value for checkboxes is an array. So the `gform_field_values` would contain a really bad encoded string that fails to validate. Saving again kills at least custom field file uploads. This fix checks to see whether the value is an array to begin with and pulls out the needed subvalue. https://secure.helpscout.net/conversation/394406485/9835/?folderId=408730
I don't recall why we added this to `gv_empty()` in the first place.…but it doesn't really make much sense. Thoughts, @soulseekah ?
Saw an empty View ID in the blacklist, might as well fix it.
It was looking bad for smaller screens, the screenshots were huge. Get rid of the `.gv-welcome-screenshots` class and use core instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
┆Issue is synchronized with this Asana task