Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Move @daffodil/cart checkout code to @daffodil/checkout #2807

Open
griest024 opened this issue May 21, 2024 · 1 comment
Open

[FEAT] Move @daffodil/cart checkout code to @daffodil/checkout #2807

griest024 opened this issue May 21, 2024 · 1 comment
Assignees
Labels
馃毃 breaking changes This PR or issue will cause a breaking change feat a new feature, enhancement, or improvement p2 medium priority package: cart @daffodil/cart package: checkout @daffodil/checkout
Milestone

Comments

@griest024
Copy link
Member

馃挕 Feature request

Feature Name

Move @daffodil/cart checkout code to @daffodil/checkout

The Desired Behavior

Some fields on cart are really more part of checkout and don't really belong on cart. DaffCart should be a collection of cart items and some totals and discounts. Shipping and billing address, shipping method, and payment are not needed for that purpose and should be moved to checkout.

Your Use Case

As an app dev, I don't want to load unnecessary code on my homepage when I load the cart module.

@griest024 griest024 added feat a new feature, enhancement, or improvement package: cart @daffodil/cart package: checkout @daffodil/checkout 馃毃 breaking changes This PR or issue will cause a breaking change p2 medium priority labels May 21, 2024
@griest024 griest024 added this to the Daffodil v1.0 milestone May 21, 2024
@griest024 griest024 self-assigned this May 21, 2024
@griest024
Copy link
Member Author

blocked by #2751

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃毃 breaking changes This PR or issue will cause a breaking change feat a new feature, enhancement, or improvement p2 medium priority package: cart @daffodil/cart package: checkout @daffodil/checkout
Projects
None yet
Development

No branches or pull requests

1 participant