Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design)!: add support for aria-controls to menu #2888

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jun 21, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: #2841

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@xelaint xelaint added the package: design @daffodil/design label Jun 21, 2024
@xelaint xelaint changed the title feat(design): menu accessibility updates feat(design)!: menu accessibility updates Jun 21, 2024
@xelaint xelaint added the status: wip This PR is WIP. It should be marked as a draft. label Jul 1, 2024
@xelaint
Copy link
Member Author

xelaint commented Jul 11, 2024

Doesn't work if using template ref to implement menu

@damienwebdev damienwebdev changed the title feat(design)!: menu accessibility updates feat(design)!: add support for aria-controls to menu Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design status: wip This PR is WIP. It should be marked as a draft.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Accessibility updates for DaffMenuComponent
2 participants