Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(design): update links in design package markdowns to absolute paths #2893

Merged
merged 10 commits into from
Jul 5, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jul 1, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: #2815

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@xelaint xelaint added the package: design @daffodil/design label Jul 1, 2024
@xelaint xelaint requested a review from griest024 July 1, 2024 17:10
@xelaint xelaint requested a review from a team as a code owner July 1, 2024 17:10
@xelaint xelaint added the status: awaiting review This PR is awaiting review label Jul 1, 2024
@griest024 griest024 requested a review from a team as a code owner July 2, 2024 23:30
@griest024
Copy link
Member

@xelaint I've pushed some changes that should generate the design docs as you need. LMK if not.

Copy link
Member

@griest024 griest024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some links in the design readme are wrong. The link generation logic does not check to see if the referenced doc exists, so bad links won't be caught during docsgen

@xelaint xelaint requested a review from griest024 July 3, 2024 13:41
@xelaint xelaint added this to the Daffodil v1.0 milestone Jul 3, 2024
libs/design/README.md Outdated Show resolved Hide resolved
libs/design/README.md Outdated Show resolved Hide resolved
@griest024 griest024 requested review from a team as code owners July 3, 2024 22:40
Co-authored-by: griest024 <griest024@gmail.com>
@xelaint xelaint requested a review from griest024 July 5, 2024 19:19
@xelaint xelaint removed the status: awaiting review This PR is awaiting review label Jul 5, 2024
@xelaint xelaint merged commit 93a9656 into develop Jul 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Links in package guides don't navigate correctly
2 participants