Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): add accessibility considerations to the notification component #2900

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jul 8, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Notification's accessibility considerations are not comprehensive enough.

Fixes: #2891

What is the new behavior?

  1. warn and danger statuses have a role="alert"
  2. notifications with actions also have a role="alert"
  3. all other notifications (i.e. default (no status), success status) have a role="status"

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added the package: design @daffodil/design label Jul 8, 2024
@xelaint xelaint added this to the Daffodil v1.0 milestone Jul 8, 2024
@xelaint xelaint requested a review from a team as a code owner July 8, 2024 16:10
@damienwebdev damienwebdev merged commit 8b5130a into develop Jul 10, 2024
13 checks passed
@damienwebdev damienwebdev deleted the notification-accessibility-update branch July 10, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Accessibility Considerations for DaffNotificationComponent
2 participants